[GitHub] [trafficserver] ywkaras commented on a diff in pull request #9531: Update logfilter to remove use of IpMap

["ywkaras (via GitHub)" <gi...@apache.org>]

ywkaras commented on code in PR #9531:
URL: https://github.com/apache/trafficserver/pull/9531#discussion_r1139522669


##########
lib/swoc/include/swoc/IPRange.h:
##########
@@ -1145,22 +1206,85 @@ class IPRangeSet
   /// @return Number of ranges in the set.
   size_t count() const;
 
+  bool empty() const;
+
   /// Remove all addresses in the set.
   void clear();
 
-protected:
-  /// Empty struct to use for payload.
-  /// This declares the struct and defines the singleton instance used.
-  static inline constexpr struct Mark {
-    using self_type = Mark;
-    /// @internal @c IPSpace requires equality / inequality operators.
-    /// These make all instance equal to each other.
-    bool operator==(self_type const &that);
-    bool operator!=(self_type const &that);
-  } MARK{};
+  /// Constant iterator for iteration over ranges.
+  class const_iterator {

Review Comment:
   Say what type or the concepts:  https://en.cppreference.com/w/cpp/iterator



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org