You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/16 18:21:13 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28234:
[SPARK-31462][INFRA] The usage of getopts and case statement is wrong in
do-release.sh
dongjoon-hyun commented on a change in pull request #28234: [SPARK-31462][INFRA] The usage of getopts and case statement is wrong in do-release.sh
URL: https://github.com/apache/spark/pull/28234#discussion_r409759680
##########
File path: dev/create-release/do-release-docker.sh
##########
@@ -62,7 +62,7 @@ while getopts "d:hj:ns:t:" opt; do
j) JAVA="$OPTARG" ;;
s) RELEASE_STEP="$OPTARG" ;;
h) usage ;;
- ?) error "Invalid option. Run with -h for help." ;;
+ \?) error "Invalid option. Run with -h for help." ;;
Review comment:
Do we need to fix line 57 by adding `"d` -> `":d`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org