You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/03/03 20:23:35 UTC

[GitHub] [commons-codec] nhojpatrick opened a new pull request #41: Codec 285 string encoder abstract test test encode null

nhojpatrick opened a new pull request #41: Codec 285 string encoder abstract test test encode null
URL: https://github.com/apache/commons-codec/pull/41
 
 
   Follow up for PR https://github.com/apache/commons-codec/pull/39
   
   From experience people write tests that don't check exceptions correctly, either they are not thrown, or a different than expected line throws that exception, or it's the wrong exception, or wrong message.
   
   This test doesn't ever throw the exception listed, so why is it catching and ignoring if thrown???

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-codec] nhojpatrick commented on issue #41: Codec 285 string encoder abstract test test encode null

Posted by GitBox <gi...@apache.org>.
nhojpatrick commented on issue #41: Codec 285 string encoder abstract test test encode null
URL: https://github.com/apache/commons-codec/pull/41#issuecomment-594157715
 
 
   If easier I can collapse these into the CODEC-285 PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-codec] coveralls commented on issue #41: Codec 285 string encoder abstract test test encode null

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #41: Codec 285 string encoder abstract test test encode null
URL: https://github.com/apache/commons-codec/pull/41#issuecomment-594154263
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29108630/badge)](https://coveralls.io/builds/29108630)
   
   Coverage remained the same at 93.84% when pulling **19c6d71f9cda1a63a334530e6b46a5ea401ee30d on nhojpatrick:CODEC-285_StringEncoderAbstractTest_testEncodeNull** into **126f90424cc8f62d928686ec20c6c8bd944b527b on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-codec] coveralls commented on issue #41: Codec 285 string encoder abstract test test encode null

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #41: Codec 285 string encoder abstract test test encode null
URL: https://github.com/apache/commons-codec/pull/41#issuecomment-594154264
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29108609/badge)](https://coveralls.io/builds/29108609)
   
   Coverage remained the same at 93.84% when pulling **19c6d71f9cda1a63a334530e6b46a5ea401ee30d on nhojpatrick:CODEC-285_StringEncoderAbstractTest_testEncodeNull** into **126f90424cc8f62d928686ec20c6c8bd944b527b on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-codec] coveralls edited a comment on issue #41: Codec 285 string encoder abstract test test encode null

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #41: Codec 285 string encoder abstract test test encode null
URL: https://github.com/apache/commons-codec/pull/41#issuecomment-594154263
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29108609/badge)](https://coveralls.io/builds/29108609)
   
   Coverage remained the same at 93.84% when pulling **19c6d71f9cda1a63a334530e6b46a5ea401ee30d on nhojpatrick:CODEC-285_StringEncoderAbstractTest_testEncodeNull** into **126f90424cc8f62d928686ec20c6c8bd944b527b on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services