You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by infil00p <gi...@git.apache.org> on 2016/01/15 22:32:24 UTC
[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/136
CB-8180: Changing methods of interception in WebViewClient class
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/infil00p/cordova-plugin-inappbrowser tel_uri_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/136.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #136
----
commit f989ed8d7f51c05e052ce36a1faa2b0d3db8059e
Author: Joe Bowser <bo...@apache.org>
Date: 2016-01-15T21:31:46Z
CB-8180: Changing methods of interception in WebViewClient class
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...
Posted by nraboy <gi...@git.apache.org>.
Github user nraboy commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/136#issuecomment-174225250
I can confirm this issue as well.
I've added my two cents to the Jira ticket, but it is causing major problems for my open source library ng-cordova-oauth as referenced in https://github.com/nraboy/ng-cordova-oauth/issues/193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/136#issuecomment-173940439
@falkobuttler it has been reported https://issues.apache.org/jira/browse/CB-10407
For now you can keep using the old version of the plugin until this is fixed and released
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/136#issuecomment-172109936
Neat, that actually worked!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...
Posted by falkobuttler <gi...@git.apache.org>.
Github user falkobuttler commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/136#issuecomment-173673675
@asfgit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...
Posted by falkobuttler <gi...@git.apache.org>.
Github user falkobuttler commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/136#issuecomment-173542915
This PR caused a major outage for our Android users due to the fact that the LOAD_START event does not fire anymore. We relied on that event to move the user to a different flow. I HIGHLY encourage you to revert that part of the change and re-introduce the `loadstart` event
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org