You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/05 12:47:14 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new issue #703: CI: improve docker test
nic-chen opened a new issue #703:
URL: https://github.com/apache/apisix-dashboard/issues/703
currently CI for docker test is too simple, it just test docker build, can not catch `docker run` error :
https://github.com/apache/apisix-dashboard/blob/v2.0/.github/workflows/test-docker.yml
we need to check:
1. docker run OK
2. access to web(page) successful, not 404
3. api for plugin orchestration works fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #703: CI: improve docker test
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #703:
URL: https://github.com/apache/apisix-dashboard/issues/703#issuecomment-722750672
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #703: CI: improve docker test
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #703:
URL: https://github.com/apache/apisix-dashboard/issues/703#issuecomment-722363904
yes, we need this. nice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #703: CI: improve docker test
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #703:
URL: https://github.com/apache/apisix-dashboard/issues/703#issuecomment-722451769
How about adding those tests in this PR? https://github.com/apache/apisix-dashboard/pull/701
This action is used to `Test then Deploy with Docker` if it's failed in test, then the deploy would be terminated, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed issue #703: CI: improve docker test
Posted by GitBox <gi...@apache.org>.
nic-chen closed issue #703:
URL: https://github.com/apache/apisix-dashboard/issues/703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #703: CI: improve docker test
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #703:
URL: https://github.com/apache/apisix-dashboard/issues/703#issuecomment-727861108
close since #701 merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #703: CI: improve docker test
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #703:
URL: https://github.com/apache/apisix-dashboard/issues/703#issuecomment-722451769
How about adding those tests in this PR? https://github.com/apache/apisix-dashboard/pull/701
This action is used to `Test then Deploy with Docker`, if it's failed in test, then the deploy would be terminated, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org