You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/10/20 07:04:43 UTC
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #940: ORC-1029: ServiceLoader is not thread-safe, avoid concurrent calls
dongjoon-hyun commented on a change in pull request #940:
URL: https://github.com/apache/orc/pull/940#discussion_r732470615
##########
File path: java/core/src/test/org/apache/orc/impl/TestEncryption.java
##########
@@ -140,4 +145,43 @@ public void testPushDownReadEncryption() throws IOException {
read(true);
}
+ @Test
+ @SuppressWarnings("unchecked")
+ public void testConcurrentCreation() throws InterruptedException {
Review comment:
This seems to succeed without the patch in my environment. Do I need to set something to make this fail consistently?
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache ORC 1.8.0-SNAPSHOT:
[INFO]
[INFO] Apache ORC ......................................... SUCCESS [ 1.138 s]
[INFO] ORC Shims .......................................... SUCCESS [ 1.346 s]
[INFO] ORC Core ........................................... SUCCESS [01:21 min]
[INFO] ORC MapReduce ...................................... SUCCESS [ 25.150 s]
[INFO] ORC Tools .......................................... SUCCESS [ 9.765 s]
[INFO] ORC Examples ....................................... SUCCESS [ 2.684 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:02 min
[INFO] Finished at: 2021-10-20T00:04:03-07:00
[INFO] ------------------------------------------------------------------------
m1 java:ORC-1029 ✗ $ git diff main --stat
java/core/src/test/org/apache/orc/impl/TestEncryption.java | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
```
##########
File path: java/core/src/test/org/apache/orc/impl/TestEncryption.java
##########
@@ -140,4 +145,43 @@ public void testPushDownReadEncryption() throws IOException {
read(true);
}
+ @Test
+ @SuppressWarnings("unchecked")
+ public void testConcurrentCreation() throws InterruptedException {
Review comment:
This test case seems to succeed without the patch in my environment. Do I need to set something to make this fail consistently?
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache ORC 1.8.0-SNAPSHOT:
[INFO]
[INFO] Apache ORC ......................................... SUCCESS [ 1.138 s]
[INFO] ORC Shims .......................................... SUCCESS [ 1.346 s]
[INFO] ORC Core ........................................... SUCCESS [01:21 min]
[INFO] ORC MapReduce ...................................... SUCCESS [ 25.150 s]
[INFO] ORC Tools .......................................... SUCCESS [ 9.765 s]
[INFO] ORC Examples ....................................... SUCCESS [ 2.684 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:02 min
[INFO] Finished at: 2021-10-20T00:04:03-07:00
[INFO] ------------------------------------------------------------------------
m1 java:ORC-1029 ✗ $ git diff main --stat
java/core/src/test/org/apache/orc/impl/TestEncryption.java | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org