You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Pelladi Gabor (JIRA)" <ji...@apache.org> on 2012/10/24 09:52:13 UTC
[jira] [Commented] (WW-3766) remove
struts.freemarker.mru.max.strong.size from default.properties
[ https://issues.apache.org/jira/browse/WW-3766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483060#comment-13483060 ]
Pelladi Gabor commented on WW-3766:
-----------------------------------
"I would be surprised if this is something that is a bottleneck in any real-world application."
In our load test, with 100 concurrent threads, this synchronization caused threads to go into BLOCKING state very often.
We fixed this by putting into struts.properties:
struts.freemarker.mru.max.strong.size=0
What I don't understand is: why would we want to use MruCacheStorage which is not thread-safe thus needs external synchronization, instead of SoftCacheStorage that uses a ConcurrentHashMap that is very effective at multi-threading?
I think the latter should be the default.
> remove struts.freemarker.mru.max.strong.size from default.properties
> --------------------------------------------------------------------
>
> Key: WW-3766
> URL: https://issues.apache.org/jira/browse/WW-3766
> Project: Struts 2
> Issue Type: Improvement
> Reporter: zhouyanming
> Priority: Critical
> Labels: freemarker
> Fix For: 2.3.x
>
>
> if struts.freemarker.mru.max.strong.size > 0 ,freemarker will use MruCacheStorage instead of SoftCacheStorage,and MruCacheStorage is not concurrent,it will synchronized on every call,it will affect performance.
> in TemplateCache:
> CachedTemplate cachedTemplate;
> if(isStorageConcurrent) {
> cachedTemplate = (CachedTemplate)storage.get(tk);
> }
> else {
> synchronized(storage) {
> cachedTemplate = (CachedTemplate)storage.get(tk);
> }
> }
> please remove struts.freemarker.mru.max.strong.size from default.properties lets developers make their own choice.
> a better solution is implements a concurrent MruCacheStorage for struts2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira