[GitHub] [lucene] rmuir commented on a diff in pull request #12311: Integrate the Incubating Panama Vector API

["rmuir (via GitHub)" <gi...@apache.org>]

rmuir commented on code in PR #12311:
URL: https://github.com/apache/lucene/pull/12311#discussion_r1198991426


##########
gradle/testing/defaults-tests.gradle:
##########
@@ -119,10 +119,13 @@ allprojects {
       if (rootProject.runtimeJavaVersion < JavaVersion.VERSION_16) {
         jvmArgs '--illegal-access=deny'
       }
+
+      // Disable assertions to workaround JDK-8301190
+      jvmArgs '-da:jdk.incubator.vector.LaneType'

Review Comment:
   Yeah, i think its not good to ignore it since not all uses of lucene are server-side and someone might run it e.g. in their IDE on a Turkish machine.
   
   Couple of alternatives:
   * start with JDK-21 as our first supported release. avoids the problem easily, but means nobody can use this stuff until September
   * fall back to scalar impl (e.g. pretend vector api is not enabled) if the user has Turkish or Azeri locale and jdk version < 21?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org