[GitHub] [couchdb] nickva opened a new pull request #2089: Remove local replication endpoints in CouchDB 3.x

[GitBox <gi...@apache.org>]

nickva opened a new pull request #2089: Remove local replication endpoints in CouchDB 3.x
URL: https://github.com/apache/couchdb/pull/2089
 
 
   ### Overview
   
   `local` replication endpoints do something completely unexpected from a user's
   point of view -- they replicate to and from node local databases on a random
   node. The only way this worked correctly was if someone used the backend port
   (:5986) with a single node database. However, that port is getting closed for 3.x
   release as well, so it makes even less sense to keep this functionality around.
   
   For more discussion and voting results see ML list:
   https://lists.apache.org/thread.html/ddcd9db93cee363db7da571f5cbc7f2bd24b881a34e1ef734d6a0a1c@%3Cdev.couchdb.apache.org%3E
   
   On the plus side this should speed up EUnit and Elixir tests a bit, as 3/4 of the
   replication tests don't need to run anymore. The code in replicator is also
   simplified so there is less of it to maintain.
   
   ### Testing recommendations
   
   `make eunit`
    `make elixir`
   
   Create a replication with a local db endpoint via _replicate and via _replicator
   
   ### Checklist
   
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [x] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [x] A PR for documentation changes has been made: https://github.com/apache/couchdb-documentation/pull/423
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services