You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2019/02/14 19:21:01 UTC

[GitHub] mmiklavc commented on a change in pull request #1330: METRON-1968: Messages are lost when a parser produces multiple messages and batch size is greater than 1

mmiklavc commented on a change in pull request #1330: METRON-1968: Messages are lost when a parser produces multiple messages and batch size is greater than 1
URL: https://github.com/apache/metron/pull/1330#discussion_r256966796
 
 

 ##########
 File path: metron-platform/metron-parsing/metron-parsing-storm/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java
 ##########
 @@ -77,17 +85,6 @@ public ParserBolt( String zookeeperUrl
     super(zookeeperUrl);
     this.parserRunner = parserRunner;
     this.sensorToWriterMap = sensorToWriterMap;
-
 
 Review comment:
   Can you add an inline note about why this is being removed? I assume this is part of getting rid of MessageWriter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services