You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ajay Yadava <aj...@gmail.com> on 2016/01/06 15:40:24 UTC
Review Request 41978: SLA Monitoring does not honour entity end date
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41978/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1678
https://issues.apache.org/jira/browse/FALCON-1678
Repository: falcon-git
Description
-------
SLA Monitoring does not honour entity end date
Diffs
-----
common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd
common/src/main/java/org/apache/falcon/util/DeploymentProperties.java 715b7ba
common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083
prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 1cd571e
prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java e3dd5cc
Diff: https://reviews.apache.org/r/41978/diff/
Testing
-------
Added unit tests for main and helper methods.
Thanks,
Ajay Yadava
Re: Review Request 41978: SLA Monitoring does not honour entity end
date
Posted by Ajay Yadava <aj...@gmail.com>.
> On Jan. 7, 2016, 5:57 a.m., Pallavi Rao wrote:
> > prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java, line 77
> > <https://reviews.apache.org/r/41978/diff/1/?file=1184588#file1184588line77>
> >
> > Nit : Believe some of this is already being done in the base class, can't we just invoke a method on the base class?
Just to get rid of this I had used the inheritance later on but while fixing a bug I forgot to remove this code. This is not required at all. Thanks for catching it.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41978/#review113191
-----------------------------------------------------------
On Jan. 6, 2016, 2:40 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41978/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 2:40 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1678
> https://issues.apache.org/jira/browse/FALCON-1678
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> SLA Monitoring does not honour entity end date
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd
> common/src/main/java/org/apache/falcon/util/DeploymentProperties.java 715b7ba
> common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 1cd571e
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java e3dd5cc
>
> Diff: https://reviews.apache.org/r/41978/diff/
>
>
> Testing
> -------
>
> Added unit tests for main and helper methods.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 41978: SLA Monitoring does not honour entity end
date
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41978/#review113191
-----------------------------------------------------------
prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java (line 71)
<https://reviews.apache.org/r/41978/#comment173680>
Nit : Believe some of this is already being done in the base class, can't we just invoke a method on the base class?
- Pallavi Rao
On Jan. 6, 2016, 2:40 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41978/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 2:40 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1678
> https://issues.apache.org/jira/browse/FALCON-1678
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> SLA Monitoring does not honour entity end date
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd
> common/src/main/java/org/apache/falcon/util/DeploymentProperties.java 715b7ba
> common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 1cd571e
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java e3dd5cc
>
> Diff: https://reviews.apache.org/r/41978/diff/
>
>
> Testing
> -------
>
> Added unit tests for main and helper methods.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 41978: SLA Monitoring does not honour entity end
date
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41978/#review113405
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Jan. 7, 2016, 6:37 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41978/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 6:37 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1678
> https://issues.apache.org/jira/browse/FALCON-1678
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> SLA Monitoring does not honour entity end date
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd
> common/src/main/java/org/apache/falcon/util/DeploymentProperties.java 715b7ba
> common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 1cd571e
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java e3dd5cc
>
> Diff: https://reviews.apache.org/r/41978/diff/
>
>
> Testing
> -------
>
> Added unit tests for main and helper methods.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 41978: SLA Monitoring does not honour entity end
date
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41978/#review113298
-----------------------------------------------------------
Ship it!
+1 patch looks good.
- Balu Vellanki
On Jan. 7, 2016, 6:37 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41978/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 6:37 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1678
> https://issues.apache.org/jira/browse/FALCON-1678
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> SLA Monitoring does not honour entity end date
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd
> common/src/main/java/org/apache/falcon/util/DeploymentProperties.java 715b7ba
> common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 1cd571e
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java e3dd5cc
>
> Diff: https://reviews.apache.org/r/41978/diff/
>
>
> Testing
> -------
>
> Added unit tests for main and helper methods.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 41978: SLA Monitoring does not honour entity end
date
Posted by Ajay Yadava <aj...@gmail.com>.
> On Jan. 8, 2016, 5:06 a.m., pavan kumar kolamuri wrote:
> > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, line 344
> > <https://reviews.apache.org/r/41978/diff/2/?file=1186384#file1186384line344>
> >
> > If entity end time is over why we are not calling onRemove(entity) on that ?
Good Question. If we do that then there is a risk of loosing the sla monitoring for last few instances. In this case we just don't want to add any instances after end date and monitoring for other instances should continue.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41978/#review113409
-----------------------------------------------------------
On Jan. 7, 2016, 6:37 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41978/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 6:37 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1678
> https://issues.apache.org/jira/browse/FALCON-1678
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> SLA Monitoring does not honour entity end date
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd
> common/src/main/java/org/apache/falcon/util/DeploymentProperties.java 715b7ba
> common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 1cd571e
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java e3dd5cc
>
> Diff: https://reviews.apache.org/r/41978/diff/
>
>
> Testing
> -------
>
> Added unit tests for main and helper methods.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 41978: SLA Monitoring does not honour entity end
date
Posted by Ajay Yadava <aj...@gmail.com>.
> On Jan. 8, 2016, 5:06 a.m., pavan kumar kolamuri wrote:
> > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, line 344
> > <https://reviews.apache.org/r/41978/diff/2/?file=1186384#file1186384line344>
> >
> > If entity end time is over why we are not calling onRemove(entity) on that ?
>
> Ajay Yadava wrote:
> Good Question. If we do that then there is a risk of loosing the sla monitoring for last few instances. In this case we just don't want to add any instances after end date and monitoring for other instances should continue.
>
> pavan kumar kolamuri wrote:
> Ok undertsand, but atleast after some time we should remove these entities from the list right ?
They will automatically keep getting removed from the monitored instances over time.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41978/#review113409
-----------------------------------------------------------
On Jan. 8, 2016, 10:57 a.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41978/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:57 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1678
> https://issues.apache.org/jira/browse/FALCON-1678
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> SLA Monitoring does not honour entity end date
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd
> common/src/main/java/org/apache/falcon/util/DeploymentProperties.java 715b7ba
> common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 1cd571e
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java e3dd5cc
>
> Diff: https://reviews.apache.org/r/41978/diff/
>
>
> Testing
> -------
>
> Added unit tests for main and helper methods.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 41978: SLA Monitoring does not honour entity end
date
Posted by pavan kumar kolamuri <pa...@gmail.com>.
> On Jan. 8, 2016, 5:06 a.m., pavan kumar kolamuri wrote:
> > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, line 344
> > <https://reviews.apache.org/r/41978/diff/2/?file=1186384#file1186384line344>
> >
> > If entity end time is over why we are not calling onRemove(entity) on that ?
>
> Ajay Yadava wrote:
> Good Question. If we do that then there is a risk of loosing the sla monitoring for last few instances. In this case we just don't want to add any instances after end date and monitoring for other instances should continue.
Ok undertsand, but atleast after some time we should remove these entities from the list right ?
- pavan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41978/#review113409
-----------------------------------------------------------
On Jan. 8, 2016, 10:57 a.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41978/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:57 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1678
> https://issues.apache.org/jira/browse/FALCON-1678
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> SLA Monitoring does not honour entity end date
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd
> common/src/main/java/org/apache/falcon/util/DeploymentProperties.java 715b7ba
> common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 1cd571e
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java e3dd5cc
>
> Diff: https://reviews.apache.org/r/41978/diff/
>
>
> Testing
> -------
>
> Added unit tests for main and helper methods.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 41978: SLA Monitoring does not honour entity end
date
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41978/#review113409
-----------------------------------------------------------
prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java (line 344)
<https://reviews.apache.org/r/41978/#comment174033>
If entity end time is over why we are not calling onRemove(entity) on that ?
- pavan kumar kolamuri
On Jan. 7, 2016, 6:37 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41978/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 6:37 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1678
> https://issues.apache.org/jira/browse/FALCON-1678
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> SLA Monitoring does not honour entity end date
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd
> common/src/main/java/org/apache/falcon/util/DeploymentProperties.java 715b7ba
> common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 1cd571e
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java e3dd5cc
>
> Diff: https://reviews.apache.org/r/41978/diff/
>
>
> Testing
> -------
>
> Added unit tests for main and helper methods.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 41978: SLA Monitoring does not honour entity end
date
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41978/#review113677
-----------------------------------------------------------
Ship it!
Ship It!
- pavan kumar kolamuri
On Jan. 8, 2016, 10:57 a.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41978/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:57 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1678
> https://issues.apache.org/jira/browse/FALCON-1678
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> SLA Monitoring does not honour entity end date
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd
> common/src/main/java/org/apache/falcon/util/DeploymentProperties.java 715b7ba
> common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 1cd571e
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java e3dd5cc
>
> Diff: https://reviews.apache.org/r/41978/diff/
>
>
> Testing
> -------
>
> Added unit tests for main and helper methods.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 41978: SLA Monitoring does not honour entity end
date
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41978/
-----------------------------------------------------------
(Updated Jan. 8, 2016, 10:57 a.m.)
Review request for Falcon.
Bugs: FALCON-1678
https://issues.apache.org/jira/browse/FALCON-1678
Repository: falcon-git
Description
-------
SLA Monitoring does not honour entity end date
Diffs (updated)
-----
common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd
common/src/main/java/org/apache/falcon/util/DeploymentProperties.java 715b7ba
common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083
prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 1cd571e
prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java e3dd5cc
Diff: https://reviews.apache.org/r/41978/diff/
Testing
-------
Added unit tests for main and helper methods.
Thanks,
Ajay Yadava
Re: Review Request 41978: SLA Monitoring does not honour entity end
date
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41978/
-----------------------------------------------------------
(Updated Jan. 7, 2016, 6:37 p.m.)
Review request for Falcon.
Changes
-------
Addressed the review comment and removed the setup method.
Bugs: FALCON-1678
https://issues.apache.org/jira/browse/FALCON-1678
Repository: falcon-git
Description
-------
SLA Monitoring does not honour entity end date
Diffs (updated)
-----
common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd
common/src/main/java/org/apache/falcon/util/DeploymentProperties.java 715b7ba
common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083
prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 1cd571e
prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java e3dd5cc
Diff: https://reviews.apache.org/r/41978/diff/
Testing
-------
Added unit tests for main and helper methods.
Thanks,
Ajay Yadava