You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/12 14:53:06 UTC

[GitHub] [incubator-kyuubi] zwangsheng opened a new pull request, #2339: [KYUUBI-2337] [DOCS] Access Kyuubi with Kyuubi JDBC Driver

zwangsheng opened a new pull request, #2339:
URL: https://github.com/apache/incubator-kyuubi/pull/2339

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Access Kyuubi with Kyuubi-Hive-JDBC Documentation is missing
   
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [x] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] ulysses-you closed pull request #2339: [KYUUBI #2337] [DOCS] Access Kyuubi with Kyuubi JDBC Driver

Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #2339: [KYUUBI #2337] [DOCS] Access Kyuubi with Kyuubi JDBC Driver
URL: https://github.com/apache/incubator-kyuubi/pull/2339


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] zwangsheng commented on pull request #2339: [KYUUBI#2337] [DOCS] Access Kyuubi with Kyuubi JDBC Driver

Posted by GitBox <gi...@apache.org>.
zwangsheng commented on PR #2339:
URL: https://github.com/apache/incubator-kyuubi/pull/2339#issuecomment-1097475107

   Travis CI Test Fail, this seems to have nothing to do with PR. Retest plz.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] zwangsheng commented on pull request #2339: [KYUUBI#2337] [DOCS] Access Kyuubi with Kyuubi JDBC Driver

Posted by GitBox <gi...@apache.org>.
zwangsheng commented on PR #2339:
URL: https://github.com/apache/incubator-kyuubi/pull/2339#issuecomment-1096874240

   Please help check, @yaooqinn @pan3793 @ulysses-you 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2339: [KYUUBI#2337] [DOCS] Access Kyuubi with Kyuubi JDBC Driver

Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #2339:
URL: https://github.com/apache/incubator-kyuubi/pull/2339#issuecomment-1097495036

   > > we also need to mention user if they already have hadoop-common dependency in their classpath, they should exclude hadoop-client-api from the kyuubi-hive-jdbc-shaded to avoid class confliction.
   > 
   > it sounds not easy for user ...
   
   Another option is make `hadoop-client-api` as optional, then use need to add there own hadoop jars into classpath


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2339: [KYUUBI#2337] [DOCS] Access Kyuubi with Kyuubi JDBC Driver

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2339:
URL: https://github.com/apache/incubator-kyuubi/pull/2339#issuecomment-1096898176

   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2339](https://codecov.io/gh/apache/incubator-kyuubi/pull/2339?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4bb936) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a63e811ea49a5a70b8e8b895c29aea740976c6ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a63e811) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2339      +/-   ##
   ============================================
   - Coverage     62.52%   62.51%   -0.01%     
     Complexity       69       69              
   ============================================
     Files           355      355              
     Lines         16908    16908              
     Branches       2285     2285              
   ============================================
   - Hits          10571    10570       -1     
   - Misses         5356     5358       +2     
   + Partials        981      980       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `89.28% <0.00%> (-3.58%)` | :arrow_down: |
   | [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `69.87% <0.00%> (-1.21%)` | :arrow_down: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.34% <0.00%> (+0.12%)` | :arrow_up: |
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `96.07% <0.00%> (+1.96%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2339?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2339?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a63e811...c4bb936](https://codecov.io/gh/apache/incubator-kyuubi/pull/2339?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2339: [KYUUBI#2337] [DOCS] Access Kyuubi with Kyuubi JDBC Driver

Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #2339:
URL: https://github.com/apache/incubator-kyuubi/pull/2339#issuecomment-1097477219

   We recommend using `kyuubi-hive-jdbc-shaded` because it has less transitive dependencies, and we also need to mention user if they already have `hadoop-common` dependency in there classpath, they should exclude `hadoop-client-api` from the `kyuubi-hive-jdbc-shaded` to avoid class confliction.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] zwangsheng commented on pull request #2339: [KYUUBI-2337] [DOCS] Access Kyuubi with Kyuubi JDBC Driver

Posted by GitBox <gi...@apache.org>.
zwangsheng commented on PR #2339:
URL: https://github.com/apache/incubator-kyuubi/pull/2339#issuecomment-1096836769

   Here is the screenshots for doc
   ![481649774905_ pic](https://user-images.githubusercontent.com/52876270/162991015-bc622a14-8740-4bfb-bc81-fdf673261e28.jpg)
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2339: [KYUUBI#2337] [DOCS] Access Kyuubi with Kyuubi JDBC Driver

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #2339:
URL: https://github.com/apache/incubator-kyuubi/pull/2339#discussion_r849022412


##########
docs/client/kyuubi_jdbc.md:
##########
@@ -0,0 +1,74 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements.  See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License.  You may obtain a copy of the License at
+ -
+ -   http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+<div align=center>
+
+![](../imgs/kyuubi_logo.png)
+
+</div>
+
+# Access Kyuubi with Kyuubi JDBC and ODBC Drivers

Review Comment:
   ```suggestion
   # Access Kyuubi with Kyuubi JDBC Driver
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] zwangsheng commented on pull request #2339: [KYUUBI#2337] [DOCS] Access Kyuubi with Kyuubi JDBC Driver

Posted by GitBox <gi...@apache.org>.
zwangsheng commented on PR #2339:
URL: https://github.com/apache/incubator-kyuubi/pull/2339#issuecomment-1097478394

   > We recommend using `kyuubi-hive-jdbc-shaded` because it has less transitive dependencies, and we also need to mention user if they already have `hadoop-common` dependency in their classpath, they should exclude `hadoop-client-api` from the `kyuubi-hive-jdbc-shaded` to avoid class confliction.
   
   Thanks for you reminding, will fix later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2339: [KYUUBI#2337] [DOCS] Access Kyuubi with Kyuubi JDBC Driver

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #2339:
URL: https://github.com/apache/incubator-kyuubi/pull/2339#issuecomment-1097479870

   > we also need to mention user if they already have hadoop-common dependency in their classpath, they should exclude hadoop-client-api from the kyuubi-hive-jdbc-shaded to avoid class confliction.
   
   it sounds not easy for user ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #2339: [KYUUBI #2337] [DOCS] Access Kyuubi with Kyuubi JDBC Driver

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #2339:
URL: https://github.com/apache/incubator-kyuubi/pull/2339#discussion_r849327778


##########
docs/client/kyuubi_jdbc.md:
##########
@@ -0,0 +1,101 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements.  See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License.  You may obtain a copy of the License at
+ -
+ -   http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+<div align=center>
+
+![](../imgs/kyuubi_logo.png)
+
+</div>
+
+# Access Kyuubi with Kyuubi JDBC Drivers
+
+## Install Kyuubi JDBC
+
+For programing, the easiest way to get `kyuubi-hive-jdbc-shaded` is from [the maven central](https://mvnrepository.com/artifact/org.apache.hive/hive-jdbc). For example,

Review Comment:
   how can we get kyuubi jar from hive repo ..



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2339: [KYUUBI #2337] [DOCS] Access Kyuubi with Kyuubi JDBC Driver

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #2339:
URL: https://github.com/apache/incubator-kyuubi/pull/2339#issuecomment-1097897828

   thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org