[jira] Resolved: (BUILDR-225) ArchiveTask#merge, not according to doc

["Antoine Toulme (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BUILDR-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antoine Toulme resolved BUILDR-225.
-----------------------------------

    Resolution: Fixed

Fixed some time ago. I added a spec.

18:54:08~/w/buildr>svn ci CHANGELOG spec -m "fix for BUILDR-225 ArchiveTask#merge, not according to doc"
Sending        CHANGELOG
Sending        spec/packaging/archive_spec.rb
Transmitting file data ..
Committed revision 961555.

> ArchiveTask#merge, not according to doc
> ---------------------------------------
>
>                 Key: BUILDR-225
>                 URL: https://issues.apache.org/jira/browse/BUILDR-225
>             Project: Buildr
>          Issue Type: Bug
>          Components: Packaging
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.4.2
>
>
> The doc says
> # Returns an object that supports two methods: include and exclude. You can use these methods to merge
> # only specific files. For example:
> #   zip(..).merge('src.zip').include('module1/*')
> but the implementation is:
>      source.entries.reject { |entry| entry.directory? }.each do |entry|
>             if @includes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME) } &&
>                !@excludes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME) }
> so it doesn't check directories, only files. so if the zip has module1/src/Foo.java, the pattern 'module1/*' will not match and the file will not be included

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.