You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/14 05:55:00 UTC
[GitHub] [fineract] percyashu opened a new pull request #1053: FINERACT-822 enable BadImport error check
percyashu opened a new pull request #1053:
URL: https://github.com/apache/fineract/pull/1053
FINERACT-822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] percyashu commented on pull request #1053: FINERACT-822 enable BadImport error check
Posted by GitBox <gi...@apache.org>.
percyashu commented on pull request #1053:
URL: https://github.com/apache/fineract/pull/1053#issuecomment-645062737
@vorburger Sorry this was just for badImport https://errorprone.info/bugpattern/BadImport.
I just added UnnecessaryStaticImport since there wasn't any violation in the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1053: FINERACT-822 enable BadImport error check
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1053:
URL: https://github.com/apache/fineract/pull/1053
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1053: FINERACT-822 enable BadImport error check
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1053:
URL: https://github.com/apache/fineract/pull/1053#issuecomment-645916823
> Wait a second, I've only properly reviewed this now.. are we saying that we are forbidding import static with this? That seems weird- import static are nice and useful, no? Or is this preventing some corner case that I'm not getting yet?
@vorburger , Looks like other static imports still work on the code base. Also seem @percyashu just refactored static import which could make the code difficult to read. I dont know if this will make you to change your mind?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1053: FINERACT-822 enable BadImport error check
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1053:
URL: https://github.com/apache/fineract/pull/1053#issuecomment-643757289
@percyashu this will need a rebase and conflict resolution, but perhaps it's best if you wait with doing that until I'm done with #943 which I'm doing soon (today), and pick this up tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org