[GitHub] [druid] jihoonson commented on a change in pull request #8623: Consolidate and bump the protobuf version

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #8623: Consolidate and bump the protobuf version
URL: https://github.com/apache/druid/pull/8623#discussion_r398199223
 
 

 ##########
 File path: extensions-core/protobuf-extensions/src/main/java/org/apache/druid/data/input/protobuf/ProtobufInputRowParser.java
 ##########
 @@ -127,49 +127,59 @@ void initDescriptor()
 
   private Descriptor getDescriptor(String descriptorFilePath)
   {
-    InputStream fin;
-
-    fin = this.getClass().getClassLoader().getResourceAsStream(descriptorFilePath);
+    InputStream fin = this.getClass().getClassLoader().getResourceAsStream(descriptorFilePath);
 
 Review comment:
   This was actually closed in `DynamicSchema.parseFrom()` which is a bad pattern.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org