[GitHub] [airflow] dstandish commented on a diff in pull request #33130: Refactor: Lazy loops, string operations, better sorting

["dstandish (via GitHub)" <gi...@apache.org>]

dstandish commented on code in PR #33130:
URL: https://github.com/apache/airflow/pull/33130#discussion_r1287691027


##########
airflow/configuration.py:
##########
@@ -1336,7 +1325,7 @@ def getsection(self, section: str) -> ConfigOptionsDictType | None:
             _section.update(OrderedDict(self.items(section)))
 
         section_prefix = self._env_var_name(section, "")
-        for env_var in sorted(os.environ.keys()):
+        for env_var in sorted(os.environ):

Review Comment:
   using `keys` instead of iterating the dict directly, isn't this a stylistic choice, really?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org