You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "Baunsgaard (via GitHub)" <gi...@apache.org> on 2026/06/24 11:30:05 UTC
[PR] Add sort support to compressed column groups [systemds]
Baunsgaard opened a new pull request, #2507:
URL: https://github.com/apache/systemds/pull/2507
Implement single-column sort for compressed matrices via a new AColGroup.sort that reorders the dictionary and remaps indexes. Add CLALibSort driver, IDictionary/Dictionary sort with shared index permutation, and per-column-group sort implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BWARE] Add sort support to compressed column groups [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard merged PR #2507:
URL: https://github.com/apache/systemds/pull/2507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BWARE] Add sort support to compressed column groups [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2507:
URL: https://github.com/apache/systemds/pull/2507#issuecomment-4790193400
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2507?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `194 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 71.48%. Comparing base ([`e295b40`](https://app.codecov.io/gh/apache/systemds/commit/e295b40e7bb81e6212fff938a63f08f118ed6e94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`61ac368`](https://app.codecov.io/gh/apache/systemds/commit/61ac368af3324c6838d2abc45633bfccf6fc879a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/systemds/pull/2507?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ntime/compress/colgroup/dictionary/Dictionary.java](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fcompress%2Fcolgroup%2Fdictionary%2FDictionary.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvY29tcHJlc3MvY29sZ3JvdXAvZGljdGlvbmFyeS9EaWN0aW9uYXJ5LmphdmE=) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/sysds/runtime/compress/colgroup/ColGroupSDC.java](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fcompress%2Fcolgroup%2FColGroupSDC.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvY29tcHJlc3MvY29sZ3JvdXAvQ29sR3JvdXBTREMuamF2YQ==) | 0.00% | [25 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ysds/runtime/compress/colgroup/ColGroupSDCFOR.java](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fcompress%2Fcolgroup%2FColGroupSDCFOR.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvY29tcHJlc3MvY29sZ3JvdXAvQ29sR3JvdXBTRENGT1IuamF2YQ==) | 0.00% | [24 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ds/runtime/compress/colgroup/ColGroupSDCZeros.java](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fcompress%2Fcolgroup%2FColGroupSDCZeros.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvY29tcHJlc3MvY29sZ3JvdXAvQ29sR3JvdXBTRENaZXJvcy5qYXZh) | 0.00% | [24 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...s/runtime/compress/colgroup/ColGroupSDCSingle.java](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fcompress%2Fcolgroup%2FColGroupSDCSingle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvY29tcHJlc3MvY29sZ3JvdXAvQ29sR3JvdXBTRENTaW5nbGUuamF2YQ==) | 0.00% | [22 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...time/compress/colgroup/ColGroupSDCSingleZeros.java](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fcompress%2Fcolgroup%2FColGroupSDCSingleZeros.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvY29tcHJlc3MvY29sZ3JvdXAvQ29sR3JvdXBTRENTaW5nbGVaZXJvcy5qYXZh) | 0.00% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/sysds/runtime/compress/lib/CLALibSort.java](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fcompress%2Flib%2FCLALibSort.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvY29tcHJlc3MvbGliL0NMQUxpYlNvcnQuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/sysds/runtime/compress/colgroup/ColGroupDDC.java](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fcompress%2Fcolgroup%2FColGroupDDC.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvY29tcHJlc3MvY29sZ3JvdXAvQ29sR3JvdXBEREMuamF2YQ==) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ysds/runtime/compress/colgroup/ColGroupDDCFOR.java](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fcompress%2Fcolgroup%2FColGroupDDCFOR.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvY29tcHJlc3MvY29sZ3JvdXAvQ29sR3JvdXBERENGT1IuamF2YQ==) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ess/colgroup/dictionary/MatrixBlockDictionary.java](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fcompress%2Fcolgroup%2Fdictionary%2FMatrixBlockDictionary.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvY29tcHJlc3MvY29sZ3JvdXAvZGljdGlvbmFyeS9NYXRyaXhCbG9ja0RpY3Rpb25hcnkuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [12 more](https://app.codecov.io/gh/apache/systemds/pull/2507?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2507 +/- ##
============================================
- Coverage 71.56% 71.48% -0.08%
+ Complexity 49052 49049 -3
============================================
Files 1574 1575 +1
Lines 189565 189764 +199
Branches 37188 37230 +42
============================================
- Hits 135658 135653 -5
- Misses 43422 43623 +201
- Partials 10485 10488 +3
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/systemds/pull/2507?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org