You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/10/13 09:50:30 UTC
[GitHub] [shenyu] KevinClair opened a new pull request, #4076: [type: refactor]Replace with computeIfAbsent.
KevinClair opened a new pull request, #4076:
URL: https://github.com/apache/shenyu/pull/4076
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] KevinClair merged pull request #4076: [type: refactor]Replace with computeIfAbsent.
Posted by GitBox <gi...@apache.org>.
KevinClair merged PR #4076:
URL: https://github.com/apache/shenyu/pull/4076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4076: [type: refactor]Replace with computeIfAbsent.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4076:
URL: https://github.com/apache/shenyu/pull/4076#issuecomment-1277381441
# [Codecov](https://codecov.io/gh/apache/shenyu/pull/4076?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4076](https://codecov.io/gh/apache/shenyu/pull/4076?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b06ccf) into [master](https://codecov.io/gh/apache/shenyu/commit/55bbc234cfa337c877c97a54d562857395c1c190?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (55bbc23) will **decrease** coverage by `0.25%`.
> The diff coverage is `49.31%`.
```diff
@@ Coverage Diff @@
## master #4076 +/- ##
============================================
- Coverage 69.98% 69.73% -0.26%
+ Complexity 6759 6730 -29
============================================
Files 935 937 +2
Lines 25465 25532 +67
Branches 2290 2298 +8
============================================
- Hits 17822 17805 -17
- Misses 6246 6322 +76
- Partials 1397 1405 +8
```
| [Impacted Files](https://codecov.io/gh/apache/shenyu/pull/4076?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/httpclient/exception/ShenyuTimeoutException.java](https://codecov.io/gh/apache/shenyu/pull/4076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9leGNlcHRpb24vU2hlbnl1VGltZW91dEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...u/register/instance/zookeeper/ZookeeperClient.java](https://codecov.io/gh/apache/shenyu/pull/4076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItaW5zdGFuY2Uvc2hlbnl1LXJlZ2lzdGVyLWluc3RhbmNlLXpvb2tlZXBlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3JlZ2lzdGVyL2luc3RhbmNlL3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnQuamF2YQ==) | `86.41% <0.00%> (-3.33%)` | :arrow_down: |
| [...yu/plugin/httpclient/AbstractHttpClientPlugin.java](https://codecov.io/gh/apache/shenyu/pull/4076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9BYnN0cmFjdEh0dHBDbGllbnRQbHVnaW4uamF2YQ==) | `40.00% <40.00%> (ø)` | |
| [...nyu/sdk/httpclient/HttpClientShenyuHttpClient.java](https://codecov.io/gh/apache/shenyu/pull/4076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNkay9zaGVueXUtc2RrLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zZGsvaHR0cGNsaWVudC9IdHRwQ2xpZW50U2hlbnl1SHR0cENsaWVudC5qYXZh) | `50.00% <50.00%> (ø)` | |
| [.../apache/shenyu/web/handler/GlobalErrorHandler.java](https://codecov.io/gh/apache/shenyu/pull/4076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9oYW5kbGVyL0dsb2JhbEVycm9ySGFuZGxlci5qYXZh) | `85.71% <50.00%> (-14.29%)` | :arrow_down: |
| [...zookeeper/ZookeeperInstanceRegisterRepository.java](https://codecov.io/gh/apache/shenyu/pull/4076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItaW5zdGFuY2Uvc2hlbnl1LXJlZ2lzdGVyLWluc3RhbmNlLXpvb2tlZXBlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3JlZ2lzdGVyL2luc3RhbmNlL3pvb2tlZXBlci9ab29rZWVwZXJJbnN0YW5jZVJlZ2lzdGVyUmVwb3NpdG9yeS5qYXZh) | `87.50% <69.23%> (-5.53%)` | :arrow_down: |
| [...henyu/loadbalancer/spi/RoundRobinLoadBalancer.java](https://codecov.io/gh/apache/shenyu/pull/4076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWxvYWRiYWxhbmNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2xvYWRiYWxhbmNlci9zcGkvUm91bmRSb2JpbkxvYWRCYWxhbmNlci5qYXZh) | `91.83% <100.00%> (-0.17%)` | :arrow_down: |
| [.../client/server/consul/ShenyuConsulConfigWatch.java](https://codecov.io/gh/apache/shenyu/pull/4076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50LXNlcnZlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50LXNlcnZlci1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9yZWdpc3Rlci9jbGllbnQvc2VydmVyL2NvbnN1bC9TaGVueXVDb25zdWxDb25maWdXYXRjaC5qYXZh) | `60.41% <0.00%> (-25.00%)` | :arrow_down: |
| [.../apache/shenyu/admin/model/dto/BatchCommonDTO.java](https://codecov.io/gh/apache/shenyu/pull/4076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0JhdGNoQ29tbW9uRFRPLmphdmE=) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java](https://codecov.io/gh/apache/shenyu/pull/4076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0F1dGhQYXRoV2FycERUTy5qYXZh) | `57.14% <0.00%> (-7.15%)` | :arrow_down: |
| ... and [28 more](https://codecov.io/gh/apache/shenyu/pull/4076/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org