You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/08/23 18:54:10 UTC

[PR] [SPARK-58954][BUILD] Upgrade `commons-codec` to 1.22.1 [spark]

dongjoon-hyun opened a new pull request, #58231:
URL: https://github.com/apache/spark/pull/58231

   ### What changes were proposed in this pull request?
   
   This PR aims to upgrade `commons-codec` to 1.22.1.
   
   ### Why are the changes needed?
   
   To bring the latest bug fixes.
   - https://github.com/apache/commons-codec/releases/tag/rel/commons-codec-1.22.1 (2026-07-30)
   
   The following are the fixed bugs in this release.
   - `CODEC-337`: Digest `ALL` reuses `System.in`, so only the first algorithm sees the real input.
   - `CODEC-338`: `PercentCodec` loses literal `'+'` when `plusForSpace` is enabled.
   - `CODEC-339`: `URLCodec.encodeUrl(BitSet, byte[])` allows custom safe sets to emit URL encoding control characters.
   - `CODEC-340`: `Base58.Builder.setEncodeTable(byte...)` is ignored when encoding and decoding.
   - `CODEC-341`: `Base16.Builder.setEncodeTable(byte...)` can create a codec that cannot decode its own output.
   - `CODEC-342`: `Base32.Builder.setEncodeTable(byte...)` can create a codec that cannot decode its own output.
   - `CODEC-343`: `Base32.Builder.setHexDecodeTable(boolean)` sets the encode table to a decode lookup table.
   - `CODEC-344`: `Base64.Builder.setEncodeTable(byte...)` accepts invalid custom alphabets.
   
   The previous version was released at
   - https://github.com/apache/commons-codec/releases/tag/rel/commons-codec-1.22.0 (2026-04-25)
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Pass the CIs.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58954][BUILD] Upgrade `commons-codec` to 1.22.1 [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58231:
URL: https://github.com/apache/spark/pull/58231#issuecomment-5388148485

   Thank you always, @uros-b !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58954][BUILD] Upgrade `commons-codec` to 1.22.1 [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58231:
URL: https://github.com/apache/spark/pull/58231#issuecomment-5390258448

   **Merge Summary:**
   - merged into master https://github.com/apache/spark/commit/f7e6a8b4c026ffc7fd3b77472158b3d34ef9e986
   
   *Posted by `merge_spark_pr.py`*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58954][BUILD] Upgrade `commons-codec` to 1.22.1 [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #58231: [SPARK-58954][BUILD] Upgrade `commons-codec` to 1.22.1
URL: https://github.com/apache/spark/pull/58231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58954][BUILD] Upgrade `commons-codec` to 1.22.1 [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #58231:
URL: https://github.com/apache/spark/pull/58231#issuecomment-5388144118

   Thank you @dongjoon-hyun!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org