You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "frankvicky (via GitHub)" <gi...@apache.org> on 2024/11/12 09:21:46 UTC
[PR] KAFKA-14934: KafkaClusterTestKit makes FaultHandler accessible [kafka]
frankvicky opened a new pull request, #17774:
URL: https://github.com/apache/kafka/pull/17774
JIRA: KAFKA-14934
> In KafkaClusterTestKit, we use a mock fault handler to avoid exiting the process during tests. It would be useful to expose this fault handler so tests could verify certain fault conditions (like a broker/controller failing to start)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14934: KafkaClusterTestKit makes FaultHandler accessible [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #17774:
URL: https://github.com/apache/kafka/pull/17774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14934: KafkaClusterTestKit makes FaultHandler accessible [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #17774:
URL: https://github.com/apache/kafka/pull/17774#issuecomment-2475515432
@frankvicky we need to find a way to expose the exception from the mock fault handler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14934: KafkaClusterTestKit makes FaultHandler accessible [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17774:
URL: https://github.com/apache/kafka/pull/17774#discussion_r1841833579
##########
test-common/test-common-api/src/main/java/org/apache/kafka/common/test/api/ClusterInstance.java:
##########
@@ -181,6 +182,10 @@ default Set<GroupProtocol> supportedGroupProtocols() {
void startBroker(int brokerId);
+ FaultHandlerException firstFatalException();
Review Comment:
Could you please wrap it by `Optional` as it is nullable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org