You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Enrico Olivelli <eo...@gmail.com> on 2017/06/22 14:24:16 UTC
Improvements to GitHub templates
Hi,
with the new templates it is very common to leave these lines in the PR
---
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`<Issue #>: Description of pull request`
`e.g. Issue 123: Description ...`
- [x] Make sure tests pass via `mvn clean apache-rat:check install
findbugs:check`.
- [x] Replace `<Issue #>` in the title with the actual Issue
number, if there is one.
---
This is turn will be committed by the merge script
what can we do?
1) Remove these lines from the template
2) Change the merge script to try to remove them
3) Write in the template to manually remove these lines
I would prefer solution 1)
-- Enrico
Re: Improvements to GitHub templates
Posted by Enrico Olivelli <eo...@gmail.com>.
I think we should try with 2)
Enrico
Il gio 22 giu 2017, 17:15 Sijie Guo <gu...@gmail.com> ha scritto:
> I would prefer 2). Keep the instructions there would help reminding people
> when they are creating PR.
>
> Sijie
>
> On Jun 22, 2017 7:43 AM, "Jia Zhai" <zh...@gmail.com> wrote:
>
> > Seems to me, it is not a big problem to have these lines there. :)
> > If we decide to move these lines, I would prefer solution 2) or 3).
> >
> > On Thu, Jun 22, 2017 at 10:24 PM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > Hi,
> > > with the new templates it is very common to leave these lines in the PR
> > >
> > >
> > > ---
> > > Be sure to do all of the following to help us incorporate your
> > > contribution
> > > quickly and easily:
> > >
> > > - [x] Make sure the PR title is formatted like:
> > > `<Issue #>: Description of pull request`
> > > `e.g. Issue 123: Description ...`
> > > - [x] Make sure tests pass via `mvn clean apache-rat:check install
> > > findbugs:check`.
> > > - [x] Replace `<Issue #>` in the title with the actual Issue
> > > number, if there is one.
> > >
> > > ---
> > >
> > > This is turn will be committed by the merge script
> > >
> > > what can we do?
> > > 1) Remove these lines from the template
> > > 2) Change the merge script to try to remove them
> > > 3) Write in the template to manually remove these lines
> > >
> > > I would prefer solution 1)
> > >
> > >
> > > -- Enrico
> > >
> >
>
--
-- Enrico Olivelli
Re: Improvements to GitHub templates
Posted by Sijie Guo <gu...@gmail.com>.
I would prefer 2). Keep the instructions there would help reminding people
when they are creating PR.
Sijie
On Jun 22, 2017 7:43 AM, "Jia Zhai" <zh...@gmail.com> wrote:
> Seems to me, it is not a big problem to have these lines there. :)
> If we decide to move these lines, I would prefer solution 2) or 3).
>
> On Thu, Jun 22, 2017 at 10:24 PM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Hi,
> > with the new templates it is very common to leave these lines in the PR
> >
> >
> > ---
> > Be sure to do all of the following to help us incorporate your
> > contribution
> > quickly and easily:
> >
> > - [x] Make sure the PR title is formatted like:
> > `<Issue #>: Description of pull request`
> > `e.g. Issue 123: Description ...`
> > - [x] Make sure tests pass via `mvn clean apache-rat:check install
> > findbugs:check`.
> > - [x] Replace `<Issue #>` in the title with the actual Issue
> > number, if there is one.
> >
> > ---
> >
> > This is turn will be committed by the merge script
> >
> > what can we do?
> > 1) Remove these lines from the template
> > 2) Change the merge script to try to remove them
> > 3) Write in the template to manually remove these lines
> >
> > I would prefer solution 1)
> >
> >
> > -- Enrico
> >
>
Re: Improvements to GitHub templates
Posted by Jia Zhai <zh...@gmail.com>.
Seems to me, it is not a big problem to have these lines there. :)
If we decide to move these lines, I would prefer solution 2) or 3).
On Thu, Jun 22, 2017 at 10:24 PM, Enrico Olivelli <eo...@gmail.com>
wrote:
> Hi,
> with the new templates it is very common to leave these lines in the PR
>
>
> ---
> Be sure to do all of the following to help us incorporate your
> contribution
> quickly and easily:
>
> - [x] Make sure the PR title is formatted like:
> `<Issue #>: Description of pull request`
> `e.g. Issue 123: Description ...`
> - [x] Make sure tests pass via `mvn clean apache-rat:check install
> findbugs:check`.
> - [x] Replace `<Issue #>` in the title with the actual Issue
> number, if there is one.
>
> ---
>
> This is turn will be committed by the merge script
>
> what can we do?
> 1) Remove these lines from the template
> 2) Change the merge script to try to remove them
> 3) Write in the template to manually remove these lines
>
> I would prefer solution 1)
>
>
> -- Enrico
>