[jira] [Commented] (GEODE-6611) Subprojects should be audited with respect to which plugins ought be applied

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820412#comment-16820412 ] 

ASF subversion and git services commented on GEODE-6611:
--------------------------------------------------------

Commit 447f508732929e282366794cb3fe6cf78dbe865c in geode's branch refs/heads/develop from Robert Houghton
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=447f508 ]

GEODE-6611: geode-all-bom does not import java-library (#3474)

* Also roll to Gradle 5.4

This project, per the Gradle docs, should use only java-platform plugin
and not java-library as well, or else the published artifact is wrong
for downstream consumption.  Additionally, this conflict is enforced in Gradle 5.4+

* Enable dockerizedtest plugin on gradle 5.4

Authored-by: Robert Houghton <rh...@pivotal.io>


> Subprojects should be audited with respect to which plugins ought be applied
> ----------------------------------------------------------------------------
>
>                 Key: GEODE-6611
>                 URL: https://issues.apache.org/jira/browse/GEODE-6611
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Patrick Rhomberg
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Previously, every Gradle subproject was aggressively configured via blocks like
> {noformat}
> subprojets {
>   apply plugin: 'java'
>   ...
> }
> {noformat}
> As the code base expanded, we have introduced many subprojects who do not warrant a "standard" configuration as a Java project.  For instance, in GEODE-6569, a subproject responsible for producing Geode's BOM was also producing a trivial jar.  This is the direct result of a configuration like the above.
> Modularity was restored by GEODE-6383 and such invasive configuration no longer exists.  We will soon be positioned to remove from such subprojects those plugins that do not belong.
> Each subproject should be audited and only pull in the plugins necessary.  This may resolve many tangental issues, particularly with publication, e.g., the war subproject publishing jars not fit for (direct) consumption.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)