You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Subhrat Chaudhary via Review Board <no...@reviews.apache.org> on 2023/05/20 06:48:07 UTC
Re: Review Request 74399: RANGER-4191:Expose the Ranger REST API to fetch all the roles that groups belong to
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74399/#review225476
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java
Lines 409 (patched)
<https://reviews.apache.org/r/74399/#comment314056>
getRolesByGroupName would be more appropriate name, since method is returning roles
- Subhrat Chaudhary
On April 15, 2023, 9:22 p.m., Ramachandran Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74399/
> -----------------------------------------------------------
>
> (Updated April 15, 2023, 9:22 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4191
> https://issues.apache.org/jira/browse/RANGER-4191
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Expose the below Ranger REST API to fetch all the roles that groups belong to
> /public/v2/api/roles/group/{groupName}
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java c19e3e1a1
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 85cd7dd67
> security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4f0edd2b0
> security-admin/src/test/java/org/apache/ranger/biz/TestRoleDBStore.java 75bdb5451
> security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 73a593e9f
> security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 217c1bba3
>
>
> Diff: https://reviews.apache.org/r/74399/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ramachandran Krishnan
>
>
Re: Review Request 74399: RANGER-4191:Expose the Ranger REST API to fetch all the roles that groups belong to
Posted by Ramachandran Krishnan <ra...@gmail.com>.
> On May 20, 2023, 6:48 a.m., Subhrat Chaudhary wrote:
> > security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java
> > Lines 409 (patched)
> > <https://reviews.apache.org/r/74399/diff/1/?file=2275868#file2275868line409>
> >
> > getRolesByGroupName would be more appropriate name, since method is returning roles
Done
- Ramachandran
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74399/#review225476
-----------------------------------------------------------
On May 21, 2023, 2:19 p.m., Ramachandran Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74399/
> -----------------------------------------------------------
>
> (Updated May 21, 2023, 2:19 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4191
> https://issues.apache.org/jira/browse/RANGER-4191
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Expose the below Ranger REST API to fetch all the roles that groups belong to
> /public/v2/api/roles/group/{groupName}
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java c19e3e1a1
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 7f00e9dcb
> security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4f0edd2b0
> security-admin/src/test/java/org/apache/ranger/biz/TestRoleDBStore.java 75bdb5451
> security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 73a593e9f
> security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 217c1bba3
>
>
> Diff: https://reviews.apache.org/r/74399/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ramachandran Krishnan
>
>