You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "mattcasters (via GitHub)" <gi...@apache.org> on 2026/10/17 12:07:19 UTC
[PR] Issue #8986 : Fix the connection toolbar on a Neo4j execution location (hop)
mattcasters opened a new pull request, #8987:
URL: https://github.com/apache/hop/pull/8987
Selecting a graph database connection on a Neo4j execution information location logged an error and left the edit button without an icon. `CypherConnectionSelectionLine` is a `MetaSelectionLine` subclass. The toolbar elements are declared on `MetaSelectionLine`, but the widget registered itself under the subclass name. The lookup then tried to construct a `MetaSelectionLine` with no arguments. A click failed the same way, because `getDeclaredMethod` does not see methods inherited from the base class.
The line now registers under `MetaSelectionLine`, and toolbar clicks find a listener declared on a superclass.
fixes #8986
## Test plan
- [x] `BaseGuiWidgetsStaticListenerTest` (7)
- [x] `MetaSelectionLineSubclassToolbarTest` (2) and `MetaSelectionLineFillItemsTest` (1) with `tools/with-isolated-display.sh`
- [x] Spotless and Checkstyle on `ui` and `rcp`
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #8986 : Fix the connection toolbar on a Neo4j execution location (hop)
Posted by "bamaer (via GitHub)" <gi...@apache.org>.
bamaer merged PR #8987:
URL: https://github.com/apache/hop/pull/8987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #8986 : Fix the connection toolbar on a Neo4j execution location (hop)
Posted by "bamaer (via GitHub)" <gi...@apache.org>.
bamaer commented on PR #8987:
URL: https://github.com/apache/hop/pull/8987#issuecomment-6235058347
Thanks @mattcasters. Built it and ran `BaseGuiWidgetsStaticListenerTest`, `MetaSelectionLineSubclassToolbarTest`, `MetaSelectionLineFillItemsTest` and the Neo4j `NeoConnectionSelectionLine*` tests: all green. Reverting either half of the fix makes `MetaSelectionLineSubclassToolbarTest` fail (missing edit icon, then the click logging "Unable to call method editMetadataElement"), so the test covers both. Also checked that the clear-DB-cache toolbar item and its filter still resolve the line. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org