You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/30 01:39:09 UTC
[GitHub] [airflow] kaxil opened a new pull request #11959: Log instead of raise an Error for unregistered OperatorLinks
kaxil opened a new pull request #11959:
URL: https://github.com/apache/airflow/pull/11959
Currently, if someone uses OperatorLinks that are not registered,
it will break the UI when someone clicks on that DAG.
This commit will instead log an error in the Webserver logs so that
someone can still see the DAG in different Views (graph, tree, etc).
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11959: Log instead of raise an Error for unregistered OperatorLinks
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11959:
URL: https://github.com/apache/airflow/pull/11959#issuecomment-719430350
OK. I re-run it. Let's see if the thing works :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #11959: Log instead of raise an Error for unregistered OperatorLinks
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #11959:
URL: https://github.com/apache/airflow/pull/11959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11959: Log instead of raise an Error for unregistered OperatorLinks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11959:
URL: https://github.com/apache/airflow/pull/11959#issuecomment-719405846
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #11959: Log instead of raise an Error for unregistered OperatorLinks
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #11959:
URL: https://github.com/apache/airflow/pull/11959#issuecomment-719141414
Curious if you also plan to restore support for inline operator extra links (i.e. not using plugin system) or if that approach will be deprecated?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org