You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/03 04:33:57 UTC
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8795: Update ui-template and sync UI
wu-sheng commented on a change in pull request #8795:
URL: https://github.com/apache/skywalking/pull/8795#discussion_r841158455
##########
File path: oap-server/server-starter/src/main/resources/ui-initialized-templates/browser/browser-root.json
##########
@@ -51,12 +51,35 @@
"unit": "calls / min"
}
]
+ },
+ {
+ "x": 0,
+ "y": 0,
+ "w": 24,
+ "h": 2,
+ "i": "100",
+ "type": "Text",
+ "metricTypes": [
+ ""
+ ],
+ "metrics": [
+ ""
+ ],
+ "graph": {
+ "fontColor": "blue",
+ "backgroundColor": "white",
+ "content": "Provides Browser-Side monitoring of Web-App, Versions and Pages, through Apache SkyWalking Client JS.",
Review comment:
```suggestion
"content": "Provide Browser-Side monitoring of Web-App, Versions and Pages, through Apache SkyWalking Client JS.",
```
##########
File path: oap-server/server-starter/src/main/resources/ui-initialized-templates/k8s/k8s-root.json
##########
@@ -38,14 +38,36 @@
"showYAxis": false,
"showGroup": true
},
- "standard": {},
"metrics": [
""
],
"metricTypes": [
""
],
"moved": false
+ },
+ {
+ "x": 0,
+ "y": 0,
+ "w": 24,
+ "h": 2,
+ "i": "100",
+ "type": "Text",
+ "metricTypes": [
+ ""
+ ],
+ "metrics": [
+ ""
+ ],
+ "graph": {
+ "fontColor": "blue",
+ "backgroundColor": "white",
+ "content": "Provides monitoring of the status and resources of the K8S Cluster.",
Review comment:
```suggestion
"content": "Provide monitoring of the status and resources of the K8S Cluster.",
```
##########
File path: oap-server/server-starter/src/main/resources/ui-initialized-templates/os_linux/linux-root.json
##########
@@ -51,6 +51,29 @@
"unit": "%"
}
]
+ },
+ {
+ "x": 0,
+ "y": 0,
+ "w": 24,
+ "h": 2,
+ "i": "100",
+ "type": "Text",
+ "metricTypes": [
+ ""
+ ],
+ "metrics": [
+ ""
+ ],
+ "graph": {
+ "fontColor": "blue",
+ "backgroundColor": "white",
+ "content": "Provides monitoring of the status and resources of the VMs running Linux.",
Review comment:
```suggestion
"content": "Provide Linux OS monitoring.",
```
##########
File path: oap-server/server-starter/src/main/resources/ui-initialized-templates/mesh_cp/mesh-control-plane-root.json
##########
@@ -38,14 +38,36 @@
"showYAxis": false,
"showGroup": true
},
- "standard": {},
"metrics": [
""
],
"metricTypes": [
""
],
"moved": false
+ },
+ {
+ "x": 0,
+ "y": 0,
+ "w": 24,
+ "h": 2,
+ "i": "100",
+ "type": "Text",
+ "metricTypes": [
+ ""
+ ],
+ "metrics": [
+ ""
+ ],
+ "graph": {
+ "fontColor": "blue",
+ "backgroundColor": "white",
+ "content": "Provides monitoring of the behavior of Istio through its self-monitoring metrics.",
Review comment:
```suggestion
"content": "Provide monitoring of the behavior of Istio through its self-monitoring metrics.",
```
##########
File path: oap-server/server-starter/src/main/resources/ui-initialized-templates/virtual_database/virtual-database-root.json
##########
@@ -51,6 +51,29 @@
"label": "Latency"
}
]
+ },
+ {
+ "x": 0,
+ "y": 0,
+ "w": 24,
+ "h": 2,
+ "i": "100",
+ "type": "Text",
+ "metricTypes": [
+ ""
+ ],
+ "metrics": [
+ ""
+ ],
+ "graph": {
+ "fontColor": "blue",
+ "backgroundColor": "white",
+ "content": "Observe the Virtual-Database which is conjectured by client side agent plugin.",
Review comment:
```suggestion
"content": "Observe the Virtual Database which is conjectured by language agent through various plugins.",
```
##########
File path: oap-server/server-starter/src/main/resources/ui-initialized-templates/k8s_service/k8s-service-root.json
##########
@@ -42,6 +42,29 @@
"showYAxis": false,
"showGroup": true
}
+ },
+ {
+ "x": 0,
+ "y": 0,
+ "w": 24,
+ "h": 2,
+ "i": "100",
+ "type": "Text",
+ "metricTypes": [
+ ""
+ ],
+ "metrics": [
+ ""
+ ],
+ "graph": {
+ "fontColor": "blue",
+ "backgroundColor": "white",
+ "content": "Observe Service status and resources from K8S side.",
Review comment:
```suggestion
"content": "Observe Service status and resources from Kubernetes.",
```
##########
File path: oap-server/server-starter/src/main/resources/ui-initialized-templates/os_linux/linux-root.json
##########
@@ -51,6 +51,29 @@
"unit": "%"
}
]
+ },
+ {
+ "x": 0,
+ "y": 0,
+ "w": 24,
+ "h": 2,
+ "i": "100",
+ "type": "Text",
+ "metricTypes": [
+ ""
+ ],
+ "metrics": [
+ ""
+ ],
+ "graph": {
+ "fontColor": "blue",
Review comment:
Are we changing all links to blue? Some were black only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org