You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/10/05 22:50:45 UTC

[PR] [SPARK-59991] Remove unused `operatorConfiguration.append` and fix broken `conf/` links [spark-kubernetes-operator]

dongjoon-hyun opened a new pull request, #937:
URL: https://github.com/apache/spark-kubernetes-operator/pull/937

   ### What changes were proposed in this pull request?
   
   This PR aims to remove the unused `operatorConfiguration.append` from the Helm chart and fix the broken `conf/` links in the documentation.
   
   ### Why are the changes needed?
   
   The Helm chart has never had a `conf/` directory, so `operatorConfiguration.append` has no effect in any release, e.g. [1.0.0](https://github.com/apache/spark-kubernetes-operator/releases/tag/1.0.0) (2026-07-23). However, `values.yaml` and the documentation still describe it and link to the non-existent conf files.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, `operatorConfiguration.append` is removed, but the rendered manifests are identical. The migration guide is updated.
   
   ### How was this patch tested?
   
   Pass the CIs. I also verified manually that `helm template` renders identical manifests before and after this PR.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 5.5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-59991] Remove unused `operatorConfiguration.append` and fix broken `conf/` links [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #937:
URL: https://github.com/apache/spark-kubernetes-operator/pull/937#issuecomment-6017270943

   Merged to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-59991] Remove unused `operatorConfiguration.append` and fix broken `conf/` links [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #937:
URL: https://github.com/apache/spark-kubernetes-operator/pull/937#issuecomment-6017261552

   Thank you, @peter-toth ~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-59991] Remove unused `operatorConfiguration.append` and fix broken `conf/` links [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #937:
URL: https://github.com/apache/spark-kubernetes-operator/pull/937#issuecomment-6004816456

   cc @peter-toth , @jiangzho , @TQJADE 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-59991] Remove unused `operatorConfiguration.append` and fix broken `conf/` links [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #937: [SPARK-59991] Remove unused `operatorConfiguration.append` and fix broken `conf/` links
URL: https://github.com/apache/spark-kubernetes-operator/pull/937


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org