You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2023/08/07 18:24:54 UTC

[GitHub] [trafficserver] maskit commented on a diff in pull request #10152: CID 1516688: Fix uninitialized member of AcceptOptions

maskit commented on code in PR #10152:
URL: https://github.com/apache/trafficserver/pull/10152#discussion_r1286252341


##########
iocore/net/AcceptOptions.h:
##########
@@ -25,52 +25,54 @@
 #pragma once
 
 #include "tscore/ink_inet.h"
+
 #include "I_Event.h"
+#include "I_Net.h"

Review Comment:
   Doesn't this bring a lot of dependency? I think that's the reason we have AcceptOptions.cc separately.
   
   @moonchen What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org