[GitHub] [netbeans] BradWalker commented on a diff in pull request #5714: Cleanup the use of Double primitive wrapper.

["BradWalker (via GitHub)" <gi...@apache.org>]

BradWalker commented on code in PR #5714:
URL: https://github.com/apache/netbeans/pull/5714#discussion_r1148429243


##########
javafx/javafx2.samples/SwingInterop/src/swinginterop/SampleTableModel.java:
##########
@@ -37,9 +37,9 @@ public class SampleTableModel extends AbstractTableModel {
     private final String[] names = {"2007", "2008", "2009"};
  
     private Object[][] data = {
-            {new Double(567), new Double(956), new Double(1154)},
-            {new Double(1292), new Double(1665), new Double(1927)},
-            {new Double(1292), new Double(2559), new Double(2774)}
+            {Double.valueOf(567D),  Double.valueOf(956D),  Double.valueOf(1154D)},
+            {Double.valueOf(1292D), Double.valueOf(1665D), Double.valueOf(1927D)},
+            {Double.valueOf(1292D), Double.valueOf(2559D), Double.valueOf(2774D)}

Review Comment:
   I agree.. I realize this is partly "style" related, I just couldn't decided how far to take this.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists