[jira] [Commented] (MESOS-2554) Slave flaps when using --slave_subsystems that are not used for isolation.

["haosdent (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-2554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514548#comment-14514548 ] 

haosdent commented on MESOS-2554:
---------------------------------

Hi, [~jieyu] I am not clear about this. I think this code snippet in Slave::initialize() could make sure that "slave_subsystems" are exists.
{code}
// Ensure the subsystem is mounted and the Mesos root cgroup is
      // present.
      Try<string> hierarchy = cgroups::prepare(
          flags.cgroups_hierarchy,
          subsystem,
          flags.cgroups_root);

      if (hierarchy.isError()) {
        EXIT(1) << "Failed to prepare cgroup " << flags.cgroups_root
                << " for subsystem " << subsystem
                << ": " << hierarchy.error();
      }
{code}

> Slave flaps when using --slave_subsystems that are not used for isolation.
> --------------------------------------------------------------------------
>
>                 Key: MESOS-2554
>                 URL: https://issues.apache.org/jira/browse/MESOS-2554
>             Project: Mesos
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.21.1, 0.22.0
>            Reporter: Jie Yu
>            Priority: Critical
>
> Say one use --slave_subsystems=cpuacct
> However, if he/she does not use cpuacct cgroup for isolation, all processes forked by the slave (e.g., tasks) will be part of the slave cgroup. This is not expected. ALso, more importantly, this will cause the slave to flap when restart because there are task processes in slave's cgroup.
> We should add a check during slave startup at least!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)