You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2020/07/21 00:55:36 UTC
[GitHub] [parquet-mr] XinDongIntel opened a new pull request #803: PARQUET-1886 CompressionCodec Provider-aware Compression Codec Lookup…
XinDongIntel opened a new pull request #803:
URL: https://github.com/apache/parquet-mr/pull/803
… for parquet-mr
Make sure you have checked _all_ steps below.
### Jira
- [ PARQUET-1886] CompressionCodec Provider-aware Compression Codec Lookup for parquet-mr
- https://issues.apache.org/jira/browse/PARQUET-1886
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] xhochy commented on pull request #803: PARQUET-1886 CompressionCodec Provider-aware Compression Codec Lookup…
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #803:
URL: https://github.com/apache/parquet-mr/pull/803#issuecomment-696200963
Has there been a spec discussion about this on the mailing list?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] xhochy edited a comment on pull request #803: PARQUET-1886 CompressionCodec Provider-aware Compression Codec Lookup…
Posted by GitBox <gi...@apache.org>.
xhochy edited a comment on pull request #803:
URL: https://github.com/apache/parquet-mr/pull/803#issuecomment-696204223
Just to clarify: This enables overloading of the compression implementation but not adding new codecs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] xhochy edited a comment on pull request #803: PARQUET-1886 CompressionCodec Provider-aware Compression Codec Lookup…
Posted by GitBox <gi...@apache.org>.
xhochy edited a comment on pull request #803:
URL: https://github.com/apache/parquet-mr/pull/803#issuecomment-696204223
Just to clarify: This enables overloading of the compression implementation but not adding new codecs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] winningsix commented on pull request #803: PARQUET-1886 CompressionCodec Provider-aware Compression Codec Lookup…
Posted by GitBox <gi...@apache.org>.
winningsix commented on pull request #803:
URL: https://github.com/apache/parquet-mr/pull/803#issuecomment-696610461
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli edited a comment on pull request #803: PARQUET-1886 CompressionCodec Provider-aware Compression Codec Lookup…
Posted by GitBox <gi...@apache.org>.
shangxinli edited a comment on pull request #803:
URL: https://github.com/apache/parquet-mr/pull/803#issuecomment-824991988
Thanks for working on it @XinDongIntel! Do you want to come to next week's Parquet Sync meeting to discuss? I know it was discussed earlier but now since we started working on new release, I think we can revisit it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] winningsix commented on pull request #803: PARQUET-1886 CompressionCodec Provider-aware Compression Codec Lookup…
Posted by GitBox <gi...@apache.org>.
winningsix commented on pull request #803:
URL: https://github.com/apache/parquet-mr/pull/803#issuecomment-696611079
Connect to https://github.com/apache/arrow/pull/8229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #803: PARQUET-1886 CompressionCodec Provider-aware Compression Codec Lookup…
Posted by GitBox <gi...@apache.org>.
shangxinli commented on pull request #803:
URL: https://github.com/apache/parquet-mr/pull/803#issuecomment-824991988
Thanks for working on it @XinDongIntel! Do you want to come to next week's Parquet Sync meeting to discuss? I know it was discussed earlier but now since we started new working on new release, I think we can revisit it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] xhochy commented on pull request #803: PARQUET-1886 CompressionCodec Provider-aware Compression Codec Lookup…
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #803:
URL: https://github.com/apache/parquet-mr/pull/803#issuecomment-696204223
Just to clarify: This enables overloading of the compression implementation but not adding new codec?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] xhochy commented on pull request #803: PARQUET-1886 CompressionCodec Provider-aware Compression Codec Lookup…
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #803:
URL: https://github.com/apache/parquet-mr/pull/803#issuecomment-696200963
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] winningsix commented on pull request #803: PARQUET-1886 CompressionCodec Provider-aware Compression Codec Lookup…
Posted by GitBox <gi...@apache.org>.
winningsix commented on pull request #803:
URL: https://github.com/apache/parquet-mr/pull/803#issuecomment-696610461
@xhochy It's overloading built-in compression implementation. And it's retrieving data from footer without introducing new spec info. Do you think we need to add it as part of spec?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org