You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by cestella <gi...@git.apache.org> on 2017/08/31 16:53:09 UTC
[GitHub] metron pull request #726: METRON-1145: Profiler mpack does not create kafka ...
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/726
METRON-1145: Profiler mpack does not create kafka acl and hbase acls correctly in kerberized cluster
## Contributor Comments
Title says it all. The management pack will not start the profiler in a kerberized cluster due to us not setting the acls correctly for the hbase tables and kafka group acls.
To test this, spin up full-dev, [kerberize it](https://github.com/apache/metron/blob/master/metron-deployment/Kerberos-ambari-setup.md) and ensure the profiler topology starts without error.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron profiler_kerb
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/726.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #726
----
commit 8e5137b13a3d3fc7848f5997c5fe28fdf8cf8181
Author: cstella <ce...@gmail.com>
Date: 2017-08-30T19:40:38Z
Setting acl's correctly.
commit b024b46820c7fc23ebe95dcadc0b9530e78ce11d
Author: cstella <ce...@gmail.com>
Date: 2017-08-31T13:52:52Z
Missing dep.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron pull request #726: METRON-1145: Profiler mpack does not create kafka ...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/726#discussion_r140087395
--- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/profiler_master.py ---
@@ -59,6 +60,9 @@ def configure(self, env, upgrade_type=None, config_dir=None):
commands.create_hbase_tables()
if params.security_enabled and not commands.is_hbase_acl_configured():
commands.set_hbase_acls()
--- End diff --
Is there a reason that we do not call `commands.set_hbase_acl_configured()` here?
---
[GitHub] metron issue #726: METRON-1145: Profiler mpack does not create kafka acl and...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/726
You should add something to the PR Template
[ ] Does this require ACL's
or something
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron pull request #726: METRON-1145: Profiler mpack does not create kafka ...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/726#discussion_r140087640
--- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/profiler_master.py ---
@@ -59,6 +60,9 @@ def configure(self, env, upgrade_type=None, config_dir=None):
commands.create_hbase_tables()
if params.security_enabled and not commands.is_hbase_acl_configured():
commands.set_hbase_acls()
--- End diff --
Sorry to bring this up on an old, closed PR, but I am currently trying to track a bug that is giving me an uber headache. :) Thought this was the easiest way to reach out.
---
[GitHub] metron pull request #726: METRON-1145: Profiler mpack does not create kafka ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/726
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron pull request #726: METRON-1145: Profiler mpack does not create kafka ...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/726#discussion_r140089410
--- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/profiler_master.py ---
@@ -59,6 +60,9 @@ def configure(self, env, upgrade_type=None, config_dir=None):
commands.create_hbase_tables()
if params.security_enabled and not commands.is_hbase_acl_configured():
commands.set_hbase_acls()
--- End diff --
Ah, daft, you're right. It works different than the Kafka ACL functions.
---
[GitHub] metron pull request #726: METRON-1145: Profiler mpack does not create kafka ...
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/726#discussion_r140088458
--- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/profiler_master.py ---
@@ -59,6 +60,9 @@ def configure(self, env, upgrade_type=None, config_dir=None):
commands.create_hbase_tables()
if params.security_enabled and not commands.is_hbase_acl_configured():
commands.set_hbase_acls()
--- End diff --
@nickwallen It happens at the end of `set_hbase_acls()`
---
[GitHub] metron issue #726: METRON-1145: Profiler mpack does not create kafka acl and...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/726
Tested this in full dev with Kerberos enabled. The profiler topology starts up without issue and data appears in HBase after creating a profile. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---