You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/22 11:58:16 UTC

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #7513: ARROW-9207: [Python] Clean-up internal FileSource class

jorisvandenbossche commented on a change in pull request #7513:
URL: https://github.com/apache/arrow/pull/7513#discussion_r443506768



##########
File path: python/pyarrow/tests/test_parquet.py
##########
@@ -579,6 +579,22 @@ def test_pandas_parquet_native_file_roundtrip(tempdir, use_legacy_dataset):
     tm.assert_frame_equal(df, df_read)
 
 
+@parametrize_legacy_dataset
+def test_parquet_read_from_buffer(tempdir, use_legacy_dataset):

Review comment:
       this test is alraedy passing on master, but just noticed that we are not explicitly testing this use case (only with a `BytesIO` or `BufferReader` objects)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org