[GitHub] gatorsmile commented on a change in pull request #23662: [SPARK-26740][SPARK-26654][SQL] Make statistics of timestamp/date columns independent from system time zones

[GitBox <gi...@apache.org>]

gatorsmile commented on a change in pull request #23662: [SPARK-26740][SPARK-26654][SQL] Make statistics of timestamp/date columns independent from system time zones
URL: https://github.com/apache/spark/pull/23662#discussion_r261012475
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
 ##########
 @@ -452,12 +453,13 @@ case class CatalogColumnStat(
       dataType: DataType): ColumnStat =
     ColumnStat(
       distinctCount = distinctCount,
-      min = min.map(CatalogColumnStat.fromExternalString(_, colName, dataType)),
-      max = max.map(CatalogColumnStat.fromExternalString(_, colName, dataType)),
+      min = min.map(CatalogColumnStat.fromExternalString(_, colName, dataType, version)),
+      max = max.map(CatalogColumnStat.fromExternalString(_, colName, dataType, version)),
       nullCount = nullCount,
       avgLen = avgLen,
       maxLen = maxLen,
-      histogram = histogram)
+      histogram = histogram,
+      version = version)
 
 Review comment:
   We need a description about this VERSION number. The future coders need to understand when we should update this and how to process this. For example, we did it in `CatalogTable`'s `createVersion`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org