You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2015/12/16 07:35:05 UTC

[GitHub] incubator-zeppelin pull request: Fix edit note name bug

GitHub user r-kamath opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/539

    Fix edit note name bug

    ### What is this PR for?
    hide and show of the editor is not functioning properly
    
    ### What type of PR is it?
    Bug fix
    
    ### Is there a relevant Jira issue?
    no
    
    ### How should this be tested?
    Click on on the note name, change the text and enter or focus out to save the new name. Hit Esc for cancel


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/r-kamath/incubator-zeppelin noteNameEditBugFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/539.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #539
    
----
commit 8d1ad4b66ed0c6be0a64d26df0b9328cf173eb9f
Author: Renjith Kamath <re...@gmail.com>
Date:   2015-12-16T06:31:17Z

    fix edit note name enter/blur fix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix edit note name bug

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/539


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix edit note name bug

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/539#issuecomment-166086215
  
    Tested, Merging if there is no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix edit note name bug

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/539#issuecomment-165015868
  
    Tested, looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---