You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/14 02:47:55 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #34280: [SPARK-36994][BUILD] Update Thrift to 0.15.0
HyukjinKwon opened a new pull request #34280:
URL: https://github.com/apache/spark/pull/34280
### What changes were proposed in this pull request?
This PR proposes to upgrade Thrift to 0.15.0.
### Why are the changes needed?
To addresses CVEs:
Component Name | Component Version Name | Vulnerability | Fixed version
-- | -- | -- | --
Apache Thrift | 0.11.0-4. | [CVE-2019-0205](https://nvd.nist.gov/vuln/detail/CVE-2019-0205) | 0.13.0
Apache Thrift | 0.11.0-4. | CVE-2019-0210 | 0.13.0
Apache Thrift | 0.11.0-4. | CVE-2020-13949 | 0.14.1
### Does this PR introduce _any_ user-facing change?
I think no. CVE-2019-0205 and CVE-2019-0210 are more a bug fix.
CVE-2020-13949 might be valid.
### How was this patch tested?
Existing tests should cover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945407473
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48829/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34280: [SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-942915331
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48708/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945814566
It seems it only support Thrift 0.13: https://github.com/apache/spark/compare/master...wangyum:thrift-0.13?expand=1
Thrift 0.14.2 will throw exception:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34280: [SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-942909444
**[Test build #144228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144228/testReport)** for PR 34280 at commit [`01d95b2`](https://github.com/apache/spark/commit/01d95b2e72fa04b0d060c98b2cd5362a4977dfef).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945364823
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48825/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945378900
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48825/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum edited a comment on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
wangyum edited a comment on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945380211
It is copied from Spark 2.4.0, Not Hive 2.3.7.
Hive 1.2.1: https://github.com/apache/hive/blob/release-1.2.1/service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java#L202-L244
Spark 2.4.0: https://github.com/apache/spark/blob/v2.4.0/sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java#L237-L278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945407473
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48829/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34280:
URL: https://github.com/apache/spark/pull/34280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945382328
**[Test build #144351 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144351/testReport)** for PR 34280 at commit [`a796548`](https://github.com/apache/spark/commit/a796548ee98b171f9894a343c93d3b76ab4a3072).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945379205
**[Test build #144351 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144351/testReport)** for PR 34280 at commit [`a796548`](https://github.com/apache/spark/commit/a796548ee98b171f9894a343c93d3b76ab4a3072).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34280: [SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-942915317
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48708/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945382356
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144351/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945360367
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144347/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945469951
@HyukjinKwon It seems we need to port https://issues.apache.org/jira/browse/HIVE-21498:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945357099
**[Test build #144347 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144347/testReport)** for PR 34280 at commit [`de3f92f`](https://github.com/apache/spark/commit/de3f92f66f49a95b1fcd7531da9341de202602e7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945378900
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48825/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945379205
**[Test build #144351 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144351/testReport)** for PR 34280 at commit [`a796548`](https://github.com/apache/spark/commit/a796548ee98b171f9894a343c93d3b76ab4a3072).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34280: [SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-942915331
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48708/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #34280: [SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-943030210
seems it's changed by [this commit](https://github.com/apache/thrift/commit/63213c17ad3fece91fdaaca8f59165ca3f41c5c1) in 0.15.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34280: [SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-942912800
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144228/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945360347
**[Test build #144347 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144347/testReport)** for PR 34280 at commit [`de3f92f`](https://github.com/apache/spark/commit/de3f92f66f49a95b1fcd7531da9341de202602e7).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945380211
It is copy from Spark 2.4.0, Not Hive 2.3.7.
Hive 1.2.1: https://github.com/apache/hive/blob/release-1.2.1/service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java#L202-L244
Spark 2.4.0: https://github.com/apache/spark/blob/v2.4.0/sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java#L237-L278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945382356
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144351/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34280: [SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-942912770
**[Test build #144228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144228/testReport)** for PR 34280 at commit [`01d95b2`](https://github.com/apache/spark/commit/01d95b2e72fa04b0d060c98b2cd5362a4977dfef).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34280: [SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-942912800
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144228/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945360367
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144347/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945357099
**[Test build #144347 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144347/testReport)** for PR 34280 at commit [`de3f92f`](https://github.com/apache/spark/commit/de3f92f66f49a95b1fcd7531da9341de202602e7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-946312110
Thanks @wangyum. feel free to take this over!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-949107939
@wangyum feel free to create a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945371205
@wangyum, I just noticed that we have some diff in Thriftserver. Just to confirm, have you made some modifications to match with Spark's Thriftversion before?
e.g.) https://github.com/apache/spark/blob/master/sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java#L241-L283 vs https://github.com/apache/hive/blob/rel/release-2.3.7/service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java#L240-L254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945389444
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48829/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-945490947
Thanks @wangyum. Yeah, probably should better do that. Would you min taking a look when you find some time? I can give a shot too but that would take a while 😢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #34280: [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-946276367
We can upgrade to Thrift 0.16 with these changes: https://github.com/apache/spark/compare/master...wangyum:thrift-0.15?expand=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34280: [SPARK-36994][BUILD] Update Thrift to 0.15.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34280:
URL: https://github.com/apache/spark/pull/34280#issuecomment-942909444
**[Test build #144228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144228/testReport)** for PR 34280 at commit [`01d95b2`](https://github.com/apache/spark/commit/01d95b2e72fa04b0d060c98b2cd5362a4977dfef).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org