You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Manikumar <ma...@gmail.com> on 2018/07/23 14:30:08 UTC
[DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Hi all,
I have created a KIP to use AdminClient API in AclCommand (kafka-acls.sh)
*https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API*
<https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API>
Please take a look.
Thanks,
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Colin McCabe <cm...@apache.org>.
Hi Manikumar,
It's great that you are taking a look at this! Much needed.
Just one note: I assume that --authorizer-properties is no longer required if the --bootstrap-server option is specified. We should probably spell this out somewhere in the KIP.
thanks,
Colin
On Mon, Jul 30, 2018, at 06:47, Manikumar wrote:
> Bumping this up!
>
> On Mon, Jul 23, 2018 at 8:00 PM Manikumar <ma...@gmail.com> wrote:
>
> > Hi all,
> >
> > I have created a KIP to use AdminClient API in AclCommand (kafka-acls.sh)
> >
> >
> > *https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API*
> >
> > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API>
> >
> > Please take a look.
> >
> > Thanks,
> >
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Manikumar <ma...@gmail.com>.
Bumping this up!
On Mon, Jul 23, 2018 at 8:00 PM Manikumar <ma...@gmail.com> wrote:
> Hi all,
>
> I have created a KIP to use AdminClient API in AclCommand (kafka-acls.sh)
>
>
> *https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API*
>
> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API>
>
> Please take a look.
>
> Thanks,
>
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Colin McCabe <cm...@apache.org>.
Thanks, Manikumar. Sounds good.
best,
Colin
On Mon, Aug 6, 2018, at 08:57, Manikumar wrote:
> Hi All,
>
> For this KIP, I will be using "--command-config" option name to specify
> config file.
> We can handle the naming discrepancies as part of KIP-14.
>
> Thanks,
>
>
>
>
>
> On Sat, Aug 4, 2018 at 4:53 AM Jason Gustafson <ja...@confluent.io> wrote:
>
> > Here's hoping someone has time to pick up KIP-14 again:
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-14+-+Tools+Standardization
> > .
> > The inconsistencies are so irritating.
> >
> > -Jason
> >
> > On Fri, Aug 3, 2018 at 10:27 AM, Rajini Sivaram <ra...@gmail.com>
> > wrote:
> >
> > > Hi Dong,
> > >
> > > I don't have a preference for the option itself, but we are using "
> > > --command-config" in ConfigCommand, ConsumerGroupCommand,
> > > BrokerApiVersionsCommand, DeleteRecordsCommand. So it feels like we
> > should
> > > use the same here. I think we are currently only using "--config-file"
> > > StreamsResetter. I will let others comment on whether we should change to
> > > this when we add the option to other tools.
> > >
> > > Regards,
> > >
> > > Rajini
> > >
> > > On Fri, Aug 3, 2018 at 5:41 PM, Dong Lin <li...@gmail.com> wrote:
> > >
> > > > Hey Rajini, Manikumar,
> > > >
> > > > Currently kafka-streams-application-reset.sh uses "--config-file" and a
> > > > few
> > > > other tools uses "--command-config". So the config name will be
> > > > inconsistent no matter which config name we choose. Not sure we
> > currently
> > > > distinquish between core commands and non-core commands. I am wondering
> > > if
> > > > it is better to choose the name that is better in the long term. Do you
> > > > think `config-file` would be more intuitive than `command-config` here?
> > > >
> > > > Thanks,
> > > > Dong
> > > >
> > > > On Fri, Aug 3, 2018 at 2:40 AM, Manikumar <ma...@gmail.com>
> > > > wrote:
> > > >
> > > > > Updated the KIP. added a note to KIP-340 discussion thread.
> > > > >
> > > > > On Fri, Aug 3, 2018 at 2:52 PM Rajini Sivaram <
> > rajinisivaram@gmail.com
> > > >
> > > > > wrote:
> > > > >
> > > > > > Thanks Manikumar. Can you add a note to the KIP-340 discussion
> > > thread?
> > > > > >
> > > > > > On Fri, Aug 3, 2018 at 10:04 AM, Manikumar <
> > > manikumar.reddy@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Hi Rajini,
> > > > > > >
> > > > > > > Yes, I too prefer using "--command-config" . Recently in one of
> > > the
> > > > > > other
> > > > > > > KIPs (KIP-340), it was suggested to use
> > > > > > > "--config-file", So I just followed the recent suggestion. But I
> > > > think
> > > > > we
> > > > > > > should use same name in all tools (at least in core tools).
> > > > > > >
> > > > > > > If there are no concerns, I will change the option to
> > > > > > "--command-config".
> > > > > > > Since KIP-340 PR is not yet merged, we can also change there.
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > >
> > > > > > > On Fri, Aug 3, 2018 at 1:57 PM Rajini Sivaram <
> > > > rajinisivaram@gmail.com
> > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Hi Manikumar,
> > > > > > > >
> > > > > > > > We have some tools already (ConfigCommand,
> > ConsumerGroupCommand,
> > > > > > > > DelegationTokenCommand) which use "--command-config" option to
> > > > > specify
> > > > > > > > config file. Perhaps use should use the same name for
> > AclCommand
> > > as
> > > > > > well?
> > > > > > > >
> > > > > > > > On Thu, Aug 2, 2018 at 7:23 PM, Colin McCabe <
> > cmccabe@apache.org
> > > >
> > > > > > wrote:
> > > > > > > >
> > > > > > > > > +1 for starting the vote
> > > > > > > > >
> > > > > > > > > cheers,
> > > > > > > > > Colin
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Wed, Aug 1, 2018, at 08:46, Manikumar wrote:
> > > > > > > > > > Hi all,
> > > > > > > > > >
> > > > > > > > > > If there are no concerns, I will start the voting process
> > > soon.
> > > > > > > > > >
> > > > > > > > > > Thanks
> > > > > > > > > >
> > > > > > > > > > On Tue, Jul 31, 2018 at 9:08 AM Manikumar <
> > > > > > manikumar.reddy@gmail.com
> > > > > > > >
> > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > Hi Colin,
> > > > > > > > > > >
> > > > > > > > > > > Yes, "--authorizer-properties" option is not required
> > with
> > > > > > > > > > > "--bootstrap-server" option. Updated the KIP.
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > Thanks,
> > > > > > > > > > >
> > > > > > > > > > > On Tue, Jul 31, 2018 at 1:30 AM Ted Yu <
> > > yuzhihong@gmail.com>
> > > > > > > wrote:
> > > > > > > > > > >
> > > > > > > > > > >> Look good to me.
> > > > > > > > > > >>
> > > > > > > > > > >> On Mon, Jul 23, 2018 at 7:30 AM Manikumar <
> > > > > > > > manikumar.reddy@gmail.com>
> > > > > > > > > > >> wrote:
> > > > > > > > > > >>
> > > > > > > > > > >> > Hi all,
> > > > > > > > > > >> >
> > > > > > > > > > >> > I have created a KIP to use AdminClient API in
> > > AclCommand
> > > > > > > > > > >> (kafka-acls.sh)
> > > > > > > > > > >> >
> > > > > > > > > > >> > *
> > > > > > > > > > >> >
> > > > > > > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > > > > > 332%3A+Update+AclCommand+to+use+AdminClient+API*
> > > > > > > > > > >> > <
> > > > > > > > > > >> >
> > > > > > > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > > > > > 332%3A+Update+AclCommand+to+use+AdminClient+API
> > > > > > > > > > >> > >
> > > > > > > > > > >> >
> > > > > > > > > > >> > Please take a look.
> > > > > > > > > > >> >
> > > > > > > > > > >> > Thanks,
> > > > > > > > > > >> >
> > > > > > > > > > >>
> > > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Manikumar <ma...@gmail.com>.
Hi All,
For this KIP, I will be using "--command-config" option name to specify
config file.
We can handle the naming discrepancies as part of KIP-14.
Thanks,
On Sat, Aug 4, 2018 at 4:53 AM Jason Gustafson <ja...@confluent.io> wrote:
> Here's hoping someone has time to pick up KIP-14 again:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-14+-+Tools+Standardization
> .
> The inconsistencies are so irritating.
>
> -Jason
>
> On Fri, Aug 3, 2018 at 10:27 AM, Rajini Sivaram <ra...@gmail.com>
> wrote:
>
> > Hi Dong,
> >
> > I don't have a preference for the option itself, but we are using "
> > --command-config" in ConfigCommand, ConsumerGroupCommand,
> > BrokerApiVersionsCommand, DeleteRecordsCommand. So it feels like we
> should
> > use the same here. I think we are currently only using "--config-file"
> > StreamsResetter. I will let others comment on whether we should change to
> > this when we add the option to other tools.
> >
> > Regards,
> >
> > Rajini
> >
> > On Fri, Aug 3, 2018 at 5:41 PM, Dong Lin <li...@gmail.com> wrote:
> >
> > > Hey Rajini, Manikumar,
> > >
> > > Currently kafka-streams-application-reset.sh uses "--config-file" and a
> > > few
> > > other tools uses "--command-config". So the config name will be
> > > inconsistent no matter which config name we choose. Not sure we
> currently
> > > distinquish between core commands and non-core commands. I am wondering
> > if
> > > it is better to choose the name that is better in the long term. Do you
> > > think `config-file` would be more intuitive than `command-config` here?
> > >
> > > Thanks,
> > > Dong
> > >
> > > On Fri, Aug 3, 2018 at 2:40 AM, Manikumar <ma...@gmail.com>
> > > wrote:
> > >
> > > > Updated the KIP. added a note to KIP-340 discussion thread.
> > > >
> > > > On Fri, Aug 3, 2018 at 2:52 PM Rajini Sivaram <
> rajinisivaram@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Thanks Manikumar. Can you add a note to the KIP-340 discussion
> > thread?
> > > > >
> > > > > On Fri, Aug 3, 2018 at 10:04 AM, Manikumar <
> > manikumar.reddy@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Hi Rajini,
> > > > > >
> > > > > > Yes, I too prefer using "--command-config" . Recently in one of
> > the
> > > > > other
> > > > > > KIPs (KIP-340), it was suggested to use
> > > > > > "--config-file", So I just followed the recent suggestion. But I
> > > think
> > > > we
> > > > > > should use same name in all tools (at least in core tools).
> > > > > >
> > > > > > If there are no concerns, I will change the option to
> > > > > "--command-config".
> > > > > > Since KIP-340 PR is not yet merged, we can also change there.
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > >
> > > > > > On Fri, Aug 3, 2018 at 1:57 PM Rajini Sivaram <
> > > rajinisivaram@gmail.com
> > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Hi Manikumar,
> > > > > > >
> > > > > > > We have some tools already (ConfigCommand,
> ConsumerGroupCommand,
> > > > > > > DelegationTokenCommand) which use "--command-config" option to
> > > > specify
> > > > > > > config file. Perhaps use should use the same name for
> AclCommand
> > as
> > > > > well?
> > > > > > >
> > > > > > > On Thu, Aug 2, 2018 at 7:23 PM, Colin McCabe <
> cmccabe@apache.org
> > >
> > > > > wrote:
> > > > > > >
> > > > > > > > +1 for starting the vote
> > > > > > > >
> > > > > > > > cheers,
> > > > > > > > Colin
> > > > > > > >
> > > > > > > >
> > > > > > > > On Wed, Aug 1, 2018, at 08:46, Manikumar wrote:
> > > > > > > > > Hi all,
> > > > > > > > >
> > > > > > > > > If there are no concerns, I will start the voting process
> > soon.
> > > > > > > > >
> > > > > > > > > Thanks
> > > > > > > > >
> > > > > > > > > On Tue, Jul 31, 2018 at 9:08 AM Manikumar <
> > > > > manikumar.reddy@gmail.com
> > > > > > >
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > Hi Colin,
> > > > > > > > > >
> > > > > > > > > > Yes, "--authorizer-properties" option is not required
> with
> > > > > > > > > > "--bootstrap-server" option. Updated the KIP.
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > Thanks,
> > > > > > > > > >
> > > > > > > > > > On Tue, Jul 31, 2018 at 1:30 AM Ted Yu <
> > yuzhihong@gmail.com>
> > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > >> Look good to me.
> > > > > > > > > >>
> > > > > > > > > >> On Mon, Jul 23, 2018 at 7:30 AM Manikumar <
> > > > > > > manikumar.reddy@gmail.com>
> > > > > > > > > >> wrote:
> > > > > > > > > >>
> > > > > > > > > >> > Hi all,
> > > > > > > > > >> >
> > > > > > > > > >> > I have created a KIP to use AdminClient API in
> > AclCommand
> > > > > > > > > >> (kafka-acls.sh)
> > > > > > > > > >> >
> > > > > > > > > >> > *
> > > > > > > > > >> >
> > > > > > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > > > > 332%3A+Update+AclCommand+to+use+AdminClient+API*
> > > > > > > > > >> > <
> > > > > > > > > >> >
> > > > > > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > > > > 332%3A+Update+AclCommand+to+use+AdminClient+API
> > > > > > > > > >> > >
> > > > > > > > > >> >
> > > > > > > > > >> > Please take a look.
> > > > > > > > > >> >
> > > > > > > > > >> > Thanks,
> > > > > > > > > >> >
> > > > > > > > > >>
> > > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Jason Gustafson <ja...@confluent.io>.
Here's hoping someone has time to pick up KIP-14 again:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-14+-+Tools+Standardization.
The inconsistencies are so irritating.
-Jason
On Fri, Aug 3, 2018 at 10:27 AM, Rajini Sivaram <ra...@gmail.com>
wrote:
> Hi Dong,
>
> I don't have a preference for the option itself, but we are using "
> --command-config" in ConfigCommand, ConsumerGroupCommand,
> BrokerApiVersionsCommand, DeleteRecordsCommand. So it feels like we should
> use the same here. I think we are currently only using "--config-file"
> StreamsResetter. I will let others comment on whether we should change to
> this when we add the option to other tools.
>
> Regards,
>
> Rajini
>
> On Fri, Aug 3, 2018 at 5:41 PM, Dong Lin <li...@gmail.com> wrote:
>
> > Hey Rajini, Manikumar,
> >
> > Currently kafka-streams-application-reset.sh uses "--config-file" and a
> > few
> > other tools uses "--command-config". So the config name will be
> > inconsistent no matter which config name we choose. Not sure we currently
> > distinquish between core commands and non-core commands. I am wondering
> if
> > it is better to choose the name that is better in the long term. Do you
> > think `config-file` would be more intuitive than `command-config` here?
> >
> > Thanks,
> > Dong
> >
> > On Fri, Aug 3, 2018 at 2:40 AM, Manikumar <ma...@gmail.com>
> > wrote:
> >
> > > Updated the KIP. added a note to KIP-340 discussion thread.
> > >
> > > On Fri, Aug 3, 2018 at 2:52 PM Rajini Sivaram <rajinisivaram@gmail.com
> >
> > > wrote:
> > >
> > > > Thanks Manikumar. Can you add a note to the KIP-340 discussion
> thread?
> > > >
> > > > On Fri, Aug 3, 2018 at 10:04 AM, Manikumar <
> manikumar.reddy@gmail.com>
> > > > wrote:
> > > >
> > > > > Hi Rajini,
> > > > >
> > > > > Yes, I too prefer using "--command-config" . Recently in one of
> the
> > > > other
> > > > > KIPs (KIP-340), it was suggested to use
> > > > > "--config-file", So I just followed the recent suggestion. But I
> > think
> > > we
> > > > > should use same name in all tools (at least in core tools).
> > > > >
> > > > > If there are no concerns, I will change the option to
> > > > "--command-config".
> > > > > Since KIP-340 PR is not yet merged, we can also change there.
> > > > >
> > > > > Thanks,
> > > > >
> > > > >
> > > > > On Fri, Aug 3, 2018 at 1:57 PM Rajini Sivaram <
> > rajinisivaram@gmail.com
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi Manikumar,
> > > > > >
> > > > > > We have some tools already (ConfigCommand, ConsumerGroupCommand,
> > > > > > DelegationTokenCommand) which use "--command-config" option to
> > > specify
> > > > > > config file. Perhaps use should use the same name for AclCommand
> as
> > > > well?
> > > > > >
> > > > > > On Thu, Aug 2, 2018 at 7:23 PM, Colin McCabe <cmccabe@apache.org
> >
> > > > wrote:
> > > > > >
> > > > > > > +1 for starting the vote
> > > > > > >
> > > > > > > cheers,
> > > > > > > Colin
> > > > > > >
> > > > > > >
> > > > > > > On Wed, Aug 1, 2018, at 08:46, Manikumar wrote:
> > > > > > > > Hi all,
> > > > > > > >
> > > > > > > > If there are no concerns, I will start the voting process
> soon.
> > > > > > > >
> > > > > > > > Thanks
> > > > > > > >
> > > > > > > > On Tue, Jul 31, 2018 at 9:08 AM Manikumar <
> > > > manikumar.reddy@gmail.com
> > > > > >
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Hi Colin,
> > > > > > > > >
> > > > > > > > > Yes, "--authorizer-properties" option is not required with
> > > > > > > > > "--bootstrap-server" option. Updated the KIP.
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > >
> > > > > > > > > On Tue, Jul 31, 2018 at 1:30 AM Ted Yu <
> yuzhihong@gmail.com>
> > > > > wrote:
> > > > > > > > >
> > > > > > > > >> Look good to me.
> > > > > > > > >>
> > > > > > > > >> On Mon, Jul 23, 2018 at 7:30 AM Manikumar <
> > > > > > manikumar.reddy@gmail.com>
> > > > > > > > >> wrote:
> > > > > > > > >>
> > > > > > > > >> > Hi all,
> > > > > > > > >> >
> > > > > > > > >> > I have created a KIP to use AdminClient API in
> AclCommand
> > > > > > > > >> (kafka-acls.sh)
> > > > > > > > >> >
> > > > > > > > >> > *
> > > > > > > > >> >
> > > > > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > > > 332%3A+Update+AclCommand+to+use+AdminClient+API*
> > > > > > > > >> > <
> > > > > > > > >> >
> > > > > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > > > 332%3A+Update+AclCommand+to+use+AdminClient+API
> > > > > > > > >> > >
> > > > > > > > >> >
> > > > > > > > >> > Please take a look.
> > > > > > > > >> >
> > > > > > > > >> > Thanks,
> > > > > > > > >> >
> > > > > > > > >>
> > > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Rajini Sivaram <ra...@gmail.com>.
Hi Dong,
I don't have a preference for the option itself, but we are using "
--command-config" in ConfigCommand, ConsumerGroupCommand,
BrokerApiVersionsCommand, DeleteRecordsCommand. So it feels like we should
use the same here. I think we are currently only using "--config-file"
StreamsResetter. I will let others comment on whether we should change to
this when we add the option to other tools.
Regards,
Rajini
On Fri, Aug 3, 2018 at 5:41 PM, Dong Lin <li...@gmail.com> wrote:
> Hey Rajini, Manikumar,
>
> Currently kafka-streams-application-reset.sh uses "--config-file" and a
> few
> other tools uses "--command-config". So the config name will be
> inconsistent no matter which config name we choose. Not sure we currently
> distinquish between core commands and non-core commands. I am wondering if
> it is better to choose the name that is better in the long term. Do you
> think `config-file` would be more intuitive than `command-config` here?
>
> Thanks,
> Dong
>
> On Fri, Aug 3, 2018 at 2:40 AM, Manikumar <ma...@gmail.com>
> wrote:
>
> > Updated the KIP. added a note to KIP-340 discussion thread.
> >
> > On Fri, Aug 3, 2018 at 2:52 PM Rajini Sivaram <ra...@gmail.com>
> > wrote:
> >
> > > Thanks Manikumar. Can you add a note to the KIP-340 discussion thread?
> > >
> > > On Fri, Aug 3, 2018 at 10:04 AM, Manikumar <ma...@gmail.com>
> > > wrote:
> > >
> > > > Hi Rajini,
> > > >
> > > > Yes, I too prefer using "--command-config" . Recently in one of the
> > > other
> > > > KIPs (KIP-340), it was suggested to use
> > > > "--config-file", So I just followed the recent suggestion. But I
> think
> > we
> > > > should use same name in all tools (at least in core tools).
> > > >
> > > > If there are no concerns, I will change the option to
> > > "--command-config".
> > > > Since KIP-340 PR is not yet merged, we can also change there.
> > > >
> > > > Thanks,
> > > >
> > > >
> > > > On Fri, Aug 3, 2018 at 1:57 PM Rajini Sivaram <
> rajinisivaram@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Hi Manikumar,
> > > > >
> > > > > We have some tools already (ConfigCommand, ConsumerGroupCommand,
> > > > > DelegationTokenCommand) which use "--command-config" option to
> > specify
> > > > > config file. Perhaps use should use the same name for AclCommand as
> > > well?
> > > > >
> > > > > On Thu, Aug 2, 2018 at 7:23 PM, Colin McCabe <cm...@apache.org>
> > > wrote:
> > > > >
> > > > > > +1 for starting the vote
> > > > > >
> > > > > > cheers,
> > > > > > Colin
> > > > > >
> > > > > >
> > > > > > On Wed, Aug 1, 2018, at 08:46, Manikumar wrote:
> > > > > > > Hi all,
> > > > > > >
> > > > > > > If there are no concerns, I will start the voting process soon.
> > > > > > >
> > > > > > > Thanks
> > > > > > >
> > > > > > > On Tue, Jul 31, 2018 at 9:08 AM Manikumar <
> > > manikumar.reddy@gmail.com
> > > > >
> > > > > > wrote:
> > > > > > >
> > > > > > > > Hi Colin,
> > > > > > > >
> > > > > > > > Yes, "--authorizer-properties" option is not required with
> > > > > > > > "--bootstrap-server" option. Updated the KIP.
> > > > > > > >
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > >
> > > > > > > > On Tue, Jul 31, 2018 at 1:30 AM Ted Yu <yu...@gmail.com>
> > > > wrote:
> > > > > > > >
> > > > > > > >> Look good to me.
> > > > > > > >>
> > > > > > > >> On Mon, Jul 23, 2018 at 7:30 AM Manikumar <
> > > > > manikumar.reddy@gmail.com>
> > > > > > > >> wrote:
> > > > > > > >>
> > > > > > > >> > Hi all,
> > > > > > > >> >
> > > > > > > >> > I have created a KIP to use AdminClient API in AclCommand
> > > > > > > >> (kafka-acls.sh)
> > > > > > > >> >
> > > > > > > >> > *
> > > > > > > >> >
> > > > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > > 332%3A+Update+AclCommand+to+use+AdminClient+API*
> > > > > > > >> > <
> > > > > > > >> >
> > > > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > > 332%3A+Update+AclCommand+to+use+AdminClient+API
> > > > > > > >> > >
> > > > > > > >> >
> > > > > > > >> > Please take a look.
> > > > > > > >> >
> > > > > > > >> > Thanks,
> > > > > > > >> >
> > > > > > > >>
> > > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Dong Lin <li...@gmail.com>.
Hey Rajini, Manikumar,
Currently kafka-streams-application-reset.sh uses "--config-file" and a few
other tools uses "--command-config". So the config name will be
inconsistent no matter which config name we choose. Not sure we currently
distinquish between core commands and non-core commands. I am wondering if
it is better to choose the name that is better in the long term. Do you
think `config-file` would be more intuitive than `command-config` here?
Thanks,
Dong
On Fri, Aug 3, 2018 at 2:40 AM, Manikumar <ma...@gmail.com> wrote:
> Updated the KIP. added a note to KIP-340 discussion thread.
>
> On Fri, Aug 3, 2018 at 2:52 PM Rajini Sivaram <ra...@gmail.com>
> wrote:
>
> > Thanks Manikumar. Can you add a note to the KIP-340 discussion thread?
> >
> > On Fri, Aug 3, 2018 at 10:04 AM, Manikumar <ma...@gmail.com>
> > wrote:
> >
> > > Hi Rajini,
> > >
> > > Yes, I too prefer using "--command-config" . Recently in one of the
> > other
> > > KIPs (KIP-340), it was suggested to use
> > > "--config-file", So I just followed the recent suggestion. But I think
> we
> > > should use same name in all tools (at least in core tools).
> > >
> > > If there are no concerns, I will change the option to
> > "--command-config".
> > > Since KIP-340 PR is not yet merged, we can also change there.
> > >
> > > Thanks,
> > >
> > >
> > > On Fri, Aug 3, 2018 at 1:57 PM Rajini Sivaram <rajinisivaram@gmail.com
> >
> > > wrote:
> > >
> > > > Hi Manikumar,
> > > >
> > > > We have some tools already (ConfigCommand, ConsumerGroupCommand,
> > > > DelegationTokenCommand) which use "--command-config" option to
> specify
> > > > config file. Perhaps use should use the same name for AclCommand as
> > well?
> > > >
> > > > On Thu, Aug 2, 2018 at 7:23 PM, Colin McCabe <cm...@apache.org>
> > wrote:
> > > >
> > > > > +1 for starting the vote
> > > > >
> > > > > cheers,
> > > > > Colin
> > > > >
> > > > >
> > > > > On Wed, Aug 1, 2018, at 08:46, Manikumar wrote:
> > > > > > Hi all,
> > > > > >
> > > > > > If there are no concerns, I will start the voting process soon.
> > > > > >
> > > > > > Thanks
> > > > > >
> > > > > > On Tue, Jul 31, 2018 at 9:08 AM Manikumar <
> > manikumar.reddy@gmail.com
> > > >
> > > > > wrote:
> > > > > >
> > > > > > > Hi Colin,
> > > > > > >
> > > > > > > Yes, "--authorizer-properties" option is not required with
> > > > > > > "--bootstrap-server" option. Updated the KIP.
> > > > > > >
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > On Tue, Jul 31, 2018 at 1:30 AM Ted Yu <yu...@gmail.com>
> > > wrote:
> > > > > > >
> > > > > > >> Look good to me.
> > > > > > >>
> > > > > > >> On Mon, Jul 23, 2018 at 7:30 AM Manikumar <
> > > > manikumar.reddy@gmail.com>
> > > > > > >> wrote:
> > > > > > >>
> > > > > > >> > Hi all,
> > > > > > >> >
> > > > > > >> > I have created a KIP to use AdminClient API in AclCommand
> > > > > > >> (kafka-acls.sh)
> > > > > > >> >
> > > > > > >> > *
> > > > > > >> >
> > > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > 332%3A+Update+AclCommand+to+use+AdminClient+API*
> > > > > > >> > <
> > > > > > >> >
> > > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > 332%3A+Update+AclCommand+to+use+AdminClient+API
> > > > > > >> > >
> > > > > > >> >
> > > > > > >> > Please take a look.
> > > > > > >> >
> > > > > > >> > Thanks,
> > > > > > >> >
> > > > > > >>
> > > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Manikumar <ma...@gmail.com>.
Updated the KIP. added a note to KIP-340 discussion thread.
On Fri, Aug 3, 2018 at 2:52 PM Rajini Sivaram <ra...@gmail.com>
wrote:
> Thanks Manikumar. Can you add a note to the KIP-340 discussion thread?
>
> On Fri, Aug 3, 2018 at 10:04 AM, Manikumar <ma...@gmail.com>
> wrote:
>
> > Hi Rajini,
> >
> > Yes, I too prefer using "--command-config" . Recently in one of the
> other
> > KIPs (KIP-340), it was suggested to use
> > "--config-file", So I just followed the recent suggestion. But I think we
> > should use same name in all tools (at least in core tools).
> >
> > If there are no concerns, I will change the option to
> "--command-config".
> > Since KIP-340 PR is not yet merged, we can also change there.
> >
> > Thanks,
> >
> >
> > On Fri, Aug 3, 2018 at 1:57 PM Rajini Sivaram <ra...@gmail.com>
> > wrote:
> >
> > > Hi Manikumar,
> > >
> > > We have some tools already (ConfigCommand, ConsumerGroupCommand,
> > > DelegationTokenCommand) which use "--command-config" option to specify
> > > config file. Perhaps use should use the same name for AclCommand as
> well?
> > >
> > > On Thu, Aug 2, 2018 at 7:23 PM, Colin McCabe <cm...@apache.org>
> wrote:
> > >
> > > > +1 for starting the vote
> > > >
> > > > cheers,
> > > > Colin
> > > >
> > > >
> > > > On Wed, Aug 1, 2018, at 08:46, Manikumar wrote:
> > > > > Hi all,
> > > > >
> > > > > If there are no concerns, I will start the voting process soon.
> > > > >
> > > > > Thanks
> > > > >
> > > > > On Tue, Jul 31, 2018 at 9:08 AM Manikumar <
> manikumar.reddy@gmail.com
> > >
> > > > wrote:
> > > > >
> > > > > > Hi Colin,
> > > > > >
> > > > > > Yes, "--authorizer-properties" option is not required with
> > > > > > "--bootstrap-server" option. Updated the KIP.
> > > > > >
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > On Tue, Jul 31, 2018 at 1:30 AM Ted Yu <yu...@gmail.com>
> > wrote:
> > > > > >
> > > > > >> Look good to me.
> > > > > >>
> > > > > >> On Mon, Jul 23, 2018 at 7:30 AM Manikumar <
> > > manikumar.reddy@gmail.com>
> > > > > >> wrote:
> > > > > >>
> > > > > >> > Hi all,
> > > > > >> >
> > > > > >> > I have created a KIP to use AdminClient API in AclCommand
> > > > > >> (kafka-acls.sh)
> > > > > >> >
> > > > > >> > *
> > > > > >> >
> > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > 332%3A+Update+AclCommand+to+use+AdminClient+API*
> > > > > >> > <
> > > > > >> >
> > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > 332%3A+Update+AclCommand+to+use+AdminClient+API
> > > > > >> > >
> > > > > >> >
> > > > > >> > Please take a look.
> > > > > >> >
> > > > > >> > Thanks,
> > > > > >> >
> > > > > >>
> > > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Rajini Sivaram <ra...@gmail.com>.
Thanks Manikumar. Can you add a note to the KIP-340 discussion thread?
On Fri, Aug 3, 2018 at 10:04 AM, Manikumar <ma...@gmail.com>
wrote:
> Hi Rajini,
>
> Yes, I too prefer using "--command-config" . Recently in one of the other
> KIPs (KIP-340), it was suggested to use
> "--config-file", So I just followed the recent suggestion. But I think we
> should use same name in all tools (at least in core tools).
>
> If there are no concerns, I will change the option to "--command-config".
> Since KIP-340 PR is not yet merged, we can also change there.
>
> Thanks,
>
>
> On Fri, Aug 3, 2018 at 1:57 PM Rajini Sivaram <ra...@gmail.com>
> wrote:
>
> > Hi Manikumar,
> >
> > We have some tools already (ConfigCommand, ConsumerGroupCommand,
> > DelegationTokenCommand) which use "--command-config" option to specify
> > config file. Perhaps use should use the same name for AclCommand as well?
> >
> > On Thu, Aug 2, 2018 at 7:23 PM, Colin McCabe <cm...@apache.org> wrote:
> >
> > > +1 for starting the vote
> > >
> > > cheers,
> > > Colin
> > >
> > >
> > > On Wed, Aug 1, 2018, at 08:46, Manikumar wrote:
> > > > Hi all,
> > > >
> > > > If there are no concerns, I will start the voting process soon.
> > > >
> > > > Thanks
> > > >
> > > > On Tue, Jul 31, 2018 at 9:08 AM Manikumar <manikumar.reddy@gmail.com
> >
> > > wrote:
> > > >
> > > > > Hi Colin,
> > > > >
> > > > > Yes, "--authorizer-properties" option is not required with
> > > > > "--bootstrap-server" option. Updated the KIP.
> > > > >
> > > > >
> > > > > Thanks,
> > > > >
> > > > > On Tue, Jul 31, 2018 at 1:30 AM Ted Yu <yu...@gmail.com>
> wrote:
> > > > >
> > > > >> Look good to me.
> > > > >>
> > > > >> On Mon, Jul 23, 2018 at 7:30 AM Manikumar <
> > manikumar.reddy@gmail.com>
> > > > >> wrote:
> > > > >>
> > > > >> > Hi all,
> > > > >> >
> > > > >> > I have created a KIP to use AdminClient API in AclCommand
> > > > >> (kafka-acls.sh)
> > > > >> >
> > > > >> > *
> > > > >> >
> > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 332%3A+Update+AclCommand+to+use+AdminClient+API*
> > > > >> > <
> > > > >> >
> > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 332%3A+Update+AclCommand+to+use+AdminClient+API
> > > > >> > >
> > > > >> >
> > > > >> > Please take a look.
> > > > >> >
> > > > >> > Thanks,
> > > > >> >
> > > > >>
> > > > >
> > >
> >
>
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Manikumar <ma...@gmail.com>.
Hi Rajini,
Yes, I too prefer using "--command-config" . Recently in one of the other
KIPs (KIP-340), it was suggested to use
"--config-file", So I just followed the recent suggestion. But I think we
should use same name in all tools (at least in core tools).
If there are no concerns, I will change the option to "--command-config".
Since KIP-340 PR is not yet merged, we can also change there.
Thanks,
On Fri, Aug 3, 2018 at 1:57 PM Rajini Sivaram <ra...@gmail.com>
wrote:
> Hi Manikumar,
>
> We have some tools already (ConfigCommand, ConsumerGroupCommand,
> DelegationTokenCommand) which use "--command-config" option to specify
> config file. Perhaps use should use the same name for AclCommand as well?
>
> On Thu, Aug 2, 2018 at 7:23 PM, Colin McCabe <cm...@apache.org> wrote:
>
> > +1 for starting the vote
> >
> > cheers,
> > Colin
> >
> >
> > On Wed, Aug 1, 2018, at 08:46, Manikumar wrote:
> > > Hi all,
> > >
> > > If there are no concerns, I will start the voting process soon.
> > >
> > > Thanks
> > >
> > > On Tue, Jul 31, 2018 at 9:08 AM Manikumar <ma...@gmail.com>
> > wrote:
> > >
> > > > Hi Colin,
> > > >
> > > > Yes, "--authorizer-properties" option is not required with
> > > > "--bootstrap-server" option. Updated the KIP.
> > > >
> > > >
> > > > Thanks,
> > > >
> > > > On Tue, Jul 31, 2018 at 1:30 AM Ted Yu <yu...@gmail.com> wrote:
> > > >
> > > >> Look good to me.
> > > >>
> > > >> On Mon, Jul 23, 2018 at 7:30 AM Manikumar <
> manikumar.reddy@gmail.com>
> > > >> wrote:
> > > >>
> > > >> > Hi all,
> > > >> >
> > > >> > I have created a KIP to use AdminClient API in AclCommand
> > > >> (kafka-acls.sh)
> > > >> >
> > > >> > *
> > > >> >
> > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 332%3A+Update+AclCommand+to+use+AdminClient+API*
> > > >> > <
> > > >> >
> > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 332%3A+Update+AclCommand+to+use+AdminClient+API
> > > >> > >
> > > >> >
> > > >> > Please take a look.
> > > >> >
> > > >> > Thanks,
> > > >> >
> > > >>
> > > >
> >
>
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Rajini Sivaram <ra...@gmail.com>.
Hi Manikumar,
We have some tools already (ConfigCommand, ConsumerGroupCommand,
DelegationTokenCommand) which use "--command-config" option to specify
config file. Perhaps use should use the same name for AclCommand as well?
On Thu, Aug 2, 2018 at 7:23 PM, Colin McCabe <cm...@apache.org> wrote:
> +1 for starting the vote
>
> cheers,
> Colin
>
>
> On Wed, Aug 1, 2018, at 08:46, Manikumar wrote:
> > Hi all,
> >
> > If there are no concerns, I will start the voting process soon.
> >
> > Thanks
> >
> > On Tue, Jul 31, 2018 at 9:08 AM Manikumar <ma...@gmail.com>
> wrote:
> >
> > > Hi Colin,
> > >
> > > Yes, "--authorizer-properties" option is not required with
> > > "--bootstrap-server" option. Updated the KIP.
> > >
> > >
> > > Thanks,
> > >
> > > On Tue, Jul 31, 2018 at 1:30 AM Ted Yu <yu...@gmail.com> wrote:
> > >
> > >> Look good to me.
> > >>
> > >> On Mon, Jul 23, 2018 at 7:30 AM Manikumar <ma...@gmail.com>
> > >> wrote:
> > >>
> > >> > Hi all,
> > >> >
> > >> > I have created a KIP to use AdminClient API in AclCommand
> > >> (kafka-acls.sh)
> > >> >
> > >> > *
> > >> >
> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 332%3A+Update+AclCommand+to+use+AdminClient+API*
> > >> > <
> > >> >
> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 332%3A+Update+AclCommand+to+use+AdminClient+API
> > >> > >
> > >> >
> > >> > Please take a look.
> > >> >
> > >> > Thanks,
> > >> >
> > >>
> > >
>
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Colin McCabe <cm...@apache.org>.
+1 for starting the vote
cheers,
Colin
On Wed, Aug 1, 2018, at 08:46, Manikumar wrote:
> Hi all,
>
> If there are no concerns, I will start the voting process soon.
>
> Thanks
>
> On Tue, Jul 31, 2018 at 9:08 AM Manikumar <ma...@gmail.com> wrote:
>
> > Hi Colin,
> >
> > Yes, "--authorizer-properties" option is not required with
> > "--bootstrap-server" option. Updated the KIP.
> >
> >
> > Thanks,
> >
> > On Tue, Jul 31, 2018 at 1:30 AM Ted Yu <yu...@gmail.com> wrote:
> >
> >> Look good to me.
> >>
> >> On Mon, Jul 23, 2018 at 7:30 AM Manikumar <ma...@gmail.com>
> >> wrote:
> >>
> >> > Hi all,
> >> >
> >> > I have created a KIP to use AdminClient API in AclCommand
> >> (kafka-acls.sh)
> >> >
> >> > *
> >> >
> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API*
> >> > <
> >> >
> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API
> >> > >
> >> >
> >> > Please take a look.
> >> >
> >> > Thanks,
> >> >
> >>
> >
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Manikumar <ma...@gmail.com>.
Hi all,
If there are no concerns, I will start the voting process soon.
Thanks
On Tue, Jul 31, 2018 at 9:08 AM Manikumar <ma...@gmail.com> wrote:
> Hi Colin,
>
> Yes, "--authorizer-properties" option is not required with
> "--bootstrap-server" option. Updated the KIP.
>
>
> Thanks,
>
> On Tue, Jul 31, 2018 at 1:30 AM Ted Yu <yu...@gmail.com> wrote:
>
>> Look good to me.
>>
>> On Mon, Jul 23, 2018 at 7:30 AM Manikumar <ma...@gmail.com>
>> wrote:
>>
>> > Hi all,
>> >
>> > I have created a KIP to use AdminClient API in AclCommand
>> (kafka-acls.sh)
>> >
>> > *
>> >
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API*
>> > <
>> >
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API
>> > >
>> >
>> > Please take a look.
>> >
>> > Thanks,
>> >
>>
>
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Manikumar <ma...@gmail.com>.
Hi Colin,
Yes, "--authorizer-properties" option is not required with
"--bootstrap-server" option. Updated the KIP.
Thanks,
On Tue, Jul 31, 2018 at 1:30 AM Ted Yu <yu...@gmail.com> wrote:
> Look good to me.
>
> On Mon, Jul 23, 2018 at 7:30 AM Manikumar <ma...@gmail.com>
> wrote:
>
> > Hi all,
> >
> > I have created a KIP to use AdminClient API in AclCommand (kafka-acls.sh)
> >
> > *
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API*
> > <
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API
> > >
> >
> > Please take a look.
> >
> > Thanks,
> >
>
Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API
Posted by Ted Yu <yu...@gmail.com>.
Look good to me.
On Mon, Jul 23, 2018 at 7:30 AM Manikumar <ma...@gmail.com> wrote:
> Hi all,
>
> I have created a KIP to use AdminClient API in AclCommand (kafka-acls.sh)
>
> *
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API*
> <
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API
> >
>
> Please take a look.
>
> Thanks,
>