You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/05/18 16:26:59 UTC
[jira] [Commented] (SOLR-7557) Solrj doesn't handle child documents
when using queryAndStreamResponse
[ https://issues.apache.org/jira/browse/SOLR-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548071#comment-14548071 ]
ASF GitHub Bot commented on SOLR-7557:
--------------------------------------
GitHub user stiost opened a pull request:
https://github.com/apache/lucene-solr/pull/148
SOLR-7557: Fix parsing of child documents using queryAndStreamResponse
Details in Jira: https://issues.apache.org/jira/browse/SOLR-7557
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stiost/lucene-solr trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #148
----
commit 3eb060e9d3aa9d3098d4d9043d009e4ee4f321de
Author: Stian Østerhaug <st...@gmail.com>
Date: 2015-05-18T14:24:31Z
SOLR-7557: Fix parsing of child documents using queryAndStreamResponse
----
> Solrj doesn't handle child documents when using queryAndStreamResponse
> ----------------------------------------------------------------------
>
> Key: SOLR-7557
> URL: https://issues.apache.org/jira/browse/SOLR-7557
> Project: Solr
> Issue Type: Bug
> Components: SolrJ
> Affects Versions: Trunk
> Reporter: Stian Østerhaug
>
> Getting the results from a query that as child documents results in "parsing error" when using SolrClient's queryAndStreamResponse(), but not when using the regular query() method.
> The bug is caused by StreamingBinaryResponseParser's JavaBinCodec override of readSolrDocument which always returns null (the document is instead passed to the callback), but JavaBinCodec uses the method to also decode child documents.
> I have fixed this by using a simple nestedLevel variable that can be used to detect if the document being parsed is a child (and should be returned) or a parent (and should be passed to the callback).
> The fix feels kinda hacky, but it is simple. Link to a Github pull request to follow.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org