You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Ben Maurer (JIRA)" <ji...@apache.org> on 2009/05/02 18:11:30 UTC
[jira] Created: (THRIFT-479) Add javadocs for enum types
Add javadocs for enum types
---------------------------
Key: THRIFT-479
URL: https://issues.apache.org/jira/browse/THRIFT-479
Project: Thrift
Issue Type: Bug
Components: Compiler (Java)
Reporter: Ben Maurer
When you are using an IDE, there's no way to know what the relevant enum type is for a given thrift type. The compiler should generate code like:
/** @see com.foo.blah.EnumType */
public int my_enum;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-479) Add javadocs for enum types
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-479:
---------------------------------
Attachment: thrift-479-v3.patch
You are absolutely right. How's this?
> Add javadocs for enum types
> ---------------------------
>
> Key: THRIFT-479
> URL: https://issues.apache.org/jira/browse/THRIFT-479
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Ben Maurer
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-479-v2.patch, thrift-479-v3.patch, thrift-479.patch
>
>
> When you are using an IDE, there's no way to know what the relevant enum type is for a given thrift type. The compiler should generate code like:
> /** @see com.foo.blah.EnumType */
> public int my_enum;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-479) Add javadocs for enum types
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-479:
---------------------------------
Attachment: thrift-479.patch
This should do it. Comments?
> Add javadocs for enum types
> ---------------------------
>
> Key: THRIFT-479
> URL: https://issues.apache.org/jira/browse/THRIFT-479
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Ben Maurer
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-479.patch
>
>
> When you are using an IDE, there's no way to know what the relevant enum type is for a given thrift type. The compiler should generate code like:
> /** @see com.foo.blah.EnumType */
> public int my_enum;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-479) Add javadocs for enum types
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-479:
---------------------------------
Priority: Minor (was: Major)
> Add javadocs for enum types
> ---------------------------
>
> Key: THRIFT-479
> URL: https://issues.apache.org/jira/browse/THRIFT-479
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Ben Maurer
> Priority: Minor
>
> When you are using an IDE, there's no way to know what the relevant enum type is for a given thrift type. The compiler should generate code like:
> /** @see com.foo.blah.EnumType */
> public int my_enum;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-479) Add javadocs for enum types
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury resolved THRIFT-479.
----------------------------------
Resolution: Fixed
I just committed this.
> Add javadocs for enum types
> ---------------------------
>
> Key: THRIFT-479
> URL: https://issues.apache.org/jira/browse/THRIFT-479
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Ben Maurer
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-479-v2.patch, thrift-479-v3.patch, thrift-479.patch
>
>
> When you are using an IDE, there's no way to know what the relevant enum type is for a given thrift type. The compiler should generate code like:
> /** @see com.foo.blah.EnumType */
> public int my_enum;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-479) Add javadocs for enum types
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-479:
---------------------------------
Attachment: thrift-479-v2.patch
Good call, that was some unnecessary cruft.
> Add javadocs for enum types
> ---------------------------
>
> Key: THRIFT-479
> URL: https://issues.apache.org/jira/browse/THRIFT-479
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Ben Maurer
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-479-v2.patch, thrift-479.patch
>
>
> When you are using an IDE, there's no way to know what the relevant enum type is for a given thrift type. The compiler should generate code like:
> /** @see com.foo.blah.EnumType */
> public int my_enum;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-479) Add javadocs for enum types
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736824#action_12736824 ]
David Reiss commented on THRIFT-479:
------------------------------------
Why do you have to cast it?
> Add javadocs for enum types
> ---------------------------
>
> Key: THRIFT-479
> URL: https://issues.apache.org/jira/browse/THRIFT-479
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Ben Maurer
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-479.patch
>
>
> When you are using an IDE, there's no way to know what the relevant enum type is for a given thrift type. The compiler should generate code like:
> /** @see com.foo.blah.EnumType */
> public int my_enum;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-479) Add javadocs for enum types
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736844#action_12736844 ]
David Reiss commented on THRIFT-479:
------------------------------------
Seems fine. Does the output actually match Ben's description? I think he wants it to automatically reference the appropriate type.
> Add javadocs for enum types
> ---------------------------
>
> Key: THRIFT-479
> URL: https://issues.apache.org/jira/browse/THRIFT-479
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Ben Maurer
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-479-v2.patch, thrift-479.patch
>
>
> When you are using an IDE, there's no way to know what the relevant enum type is for a given thrift type. The compiler should generate code like:
> /** @see com.foo.blah.EnumType */
> public int my_enum;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-479) Add javadocs for enum types
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736876#action_12736876 ]
David Reiss commented on THRIFT-479:
------------------------------------
I didn't run it, but it looks fine.
> Add javadocs for enum types
> ---------------------------
>
> Key: THRIFT-479
> URL: https://issues.apache.org/jira/browse/THRIFT-479
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Ben Maurer
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-479-v2.patch, thrift-479-v3.patch, thrift-479.patch
>
>
> When you are using an IDE, there's no way to know what the relevant enum type is for a given thrift type. The compiler should generate code like:
> /** @see com.foo.blah.EnumType */
> public int my_enum;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-479) Add javadocs for enum types
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-479:
---------------------------------
Patch Info: [Patch Available]
Fix Version/s: 0.2
Assignee: Bryan Duxbury
> Add javadocs for enum types
> ---------------------------
>
> Key: THRIFT-479
> URL: https://issues.apache.org/jira/browse/THRIFT-479
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Ben Maurer
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-479.patch
>
>
> When you are using an IDE, there's no way to know what the relevant enum type is for a given thrift type. The compiler should generate code like:
> /** @see com.foo.blah.EnumType */
> public int my_enum;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.