You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "fatih-acar (via GitHub)" <gi...@apache.org> on 2023/09/05 17:57:19 UTC

[GitHub] [trafficcontrol] fatih-acar commented on a diff in pull request #7741: fix(t3c): regex for pparam should check end of path

fatih-acar commented on code in PR #7741:
URL: https://github.com/apache/trafficcontrol/pull/7741#discussion_r1316219342


##########
cache-config/t3c-check-refs/t3c-check-refs.go:
##########
@@ -115,7 +115,7 @@ func checkConfigLine(line string, lineNumber int, filesAdding map[string]struct{
 				// are assumed to be configuration files and are checked that they
 				// exist in the filesystem at the absolute location in the name
 				// or relative to the ATS configuration files directory.
-				m := regexp.MustCompile(`^*(\.config|\.cfg|\.txt|\.yml|\.yaml|\.lua)+`)
+				m := regexp.MustCompile(`^*(\.config|\.cfg|\.txt|\.yml|\.yaml|\.lua)$`)

Review Comment:
   Indeed, the beginning of the regex is not valid too and it seems the Go regexp lib is not complaining
   I have fixed that too with your suggestion, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org