You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/08/28 17:52:47 UTC

[Impala-ASF-CR] [DOCS] CONCAT function returns NULL if any argument is NULL

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14156


Change subject: [DOCS] CONCAT function returns NULL if any argument is NULL
......................................................................

[DOCS] CONCAT function returns NULL if any argument is NULL

Change-Id: Ieadd249881b45944a870a616abf75ff4386615ea
---
M docs/topics/impala_string_functions.xml
1 file changed, 10 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/14156/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieadd249881b45944a870a616abf75ff4386615ea
Gerrit-Change-Number: 14156
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] [DOCS] CONCAT function returns NULL if any argument is NULL

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14156 )

Change subject: [DOCS] CONCAT function returns NULL if any argument is NULL
......................................................................

[DOCS] CONCAT function returns NULL if any argument is NULL

Change-Id: Ieadd249881b45944a870a616abf75ff4386615ea
Reviewed-on: http://gerrit.cloudera.org:8080/14156
Reviewed-by: Greg Rahn <gr...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_string_functions.xml
1 file changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Greg Rahn: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieadd249881b45944a870a616abf75ff4386615ea
Gerrit-Change-Number: 14156
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] [DOCS] CONCAT function returns NULL if any argument is NULL

Posted by "Greg Rahn (Code Review)" <ge...@cloudera.org>.
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/14156 )

Change subject: [DOCS] CONCAT function returns NULL if any argument is NULL
......................................................................


Patch Set 1: Code-Review+2

LGTM - Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/14156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieadd249881b45944a870a616abf75ff4386615ea
Gerrit-Change-Number: 14156
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Aug 2019 18:13:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] CONCAT function returns NULL if any argument is NULL

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14156 )

Change subject: [DOCS] CONCAT function returns NULL if any argument is NULL
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/471/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/14156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieadd249881b45944a870a616abf75ff4386615ea
Gerrit-Change-Number: 14156
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Aug 2019 19:22:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] CONCAT function returns NULL if any argument is NULL

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14156 )

Change subject: [DOCS] CONCAT function returns NULL if any argument is NULL
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/471/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/14156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieadd249881b45944a870a616abf75ff4386615ea
Gerrit-Change-Number: 14156
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Aug 2019 17:52:55 +0000
Gerrit-HasComments: No