[jira] [Commented] (CALCITE-766) RexBuilder.ensureType() does not correctly handle the case when nullability needs to be ignored

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600328#comment-14600328 ] 

Julian Hyde commented on CALCITE-766:
-------------------------------------

Are you sure you haven't got the sense of the argument wrong? The javadoc comment has misled me in the past. Try passing true instead of false, or vice versa.

> RexBuilder.ensureType() does not correctly handle the case when nullability needs to be ignored
> -----------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-766
>                 URL: https://issues.apache.org/jira/browse/CALCITE-766
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Mehant Baid
>            Assignee: Julian Hyde
>
> In ensureType() we don't correctly handle the case when nullability should be ignored. We still compare digests of the two types which returns false even when the types are the same but differ only in nullability. 
> Created a [Pull Request|https://github.com/apache/incubator-calcite/pull/97] with the description of the issue and a unit test. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)