You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "pkarashchenko (via GitHub)" <gi...@apache.org> on 2023/04/18 10:01:51 UTC
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8876: arch/arm64: fixed cache issue and add more cache interface
pkarashchenko commented on code in PR #8876:
URL: https://github.com/apache/nuttx/pull/8876#discussion_r1169789469
##########
arch/arm64/src/common/arm64_mpu.h:
##########
@@ -202,13 +202,23 @@
.mair_idx = MPU_MAIR_INDEX_DEVICE, \
}
-#define REGION_RAM_ATTR \
- { \
- /* AP, XN, SH */ \
- .rbar = NOT_EXEC | P_RW_U_NA_MSK | NON_SHAREABLE_MSK, \
- /* Cache-ability */ \
- .mair_idx = MPU_MAIR_INDEX_SRAM, \
- }
+#ifdef CONFIG_SMP
+# define REGION_RAM_ATTR \
+ { \
+ /* AP, XN, SH */ \
+ .rbar = (NOT_EXEC | P_RW_U_NA_MSK | INNER_SHAREABLE_MSK) , \
+ /* Cache-ability */ \
+ .mair_idx = MPU_MAIR_INDEX_SRAM, \
Review Comment:
```suggestion
# define REGION_RAM_ATTR \
{ \
/* AP, XN, SH */ \
.rbar = (NOT_EXEC | P_RW_U_NA_MSK | INNER_SHAREABLE_MSK) , \
/* Cache-ability */ \
.mair_idx = MPU_MAIR_INDEX_SRAM, \
```
##########
arch/arm64/src/common/arm64_mmu.c:
##########
@@ -584,8 +584,6 @@ int arm64_mmu_init(bool is_primary_core)
{
uint64_t val;
unsigned flags = 0;
Review Comment:
```suggestion
uint64_t val;
unsigned flags = 0;
```
##########
arch/arm64/src/common/arm64_cache.c:
##########
@@ -371,6 +415,20 @@ void up_invalidate_icache_all(void)
size_t up_get_dcache_linesize(void)
{
+ uint64_t ctr_el0;
+ uint32_t dminline;
Review Comment:
```suggestion
uint64_t ctr_el0;
uint32_t dminline;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org