[GitHub] [incubator-dubbo] satansk opened issue #3258: We should use type inference instead of explicit type parameters

["satansk (GitHub)" <gi...@apache.org>]

The source code contains many explicit type parameter use cases, such as:

```
Map<String, String> newMap = new HashMap<String, String>(reserveParams.length);
```

The old style is not suitable now, since we will support Java 8 from Dubbo 2.7, so I think we can improve it.

Since the source code is big, some tools or scripts may be helpful.


[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] satansk closed issue #3258: We should use type inference instead of explicit type parameters

["satansk (GitHub)" <gi...@apache.org>]

[ issue closed by satansk ]

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] kezhenxu94 commented on issue #3258: We should use type inference instead of explicit type parameters

["kezhenxu94 (GitHub)" <gi...@apache.org>]

Users are glad to help but review progress seems really slower than other types of PRs and they have to resolve conflicts over and over

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] satansk commented on issue #3258: We should use type inference instead of explicit type parameters

["satansk (GitHub)" <gi...@apache.org>]

I think it's OK to close it now.

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] satansk commented on issue #3258: We should use type inference instead of explicit type parameters

["satansk (GitHub)" <gi...@apache.org>]

> +1 Many users contribute to fix issues like this. I think we can leave to users who would like to help.

Yes, many contributors has done great work about this, I was looking for something like maven plugins, but failed. So let's leave it to contributors :)

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on issue #3258: We should use type inference instead of explicit type parameters

["ralf0131 (GitHub)" <gi...@apache.org>]

> Users are glad to help but review progress seems really slower than other types of PRs and they have to resolve conflicts over and over

Yes, it is a problem, I am thinking of adding a label called `level/easy` for these prs but that requires a committer to label it manually, which is not desired.
The other way is to invite more people to be a committer, who can help to review and merge. The community is on the way.
You can also help to review the pr and approve it even if you are not a committer. :) 

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on issue #3258: We should use type inference instead of explicit type parameters

["ralf0131 (GitHub)" <gi...@apache.org>]

+1 Many users contribute to fix issues like this. I think we can leave to users who would like to help.

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on issue #3258: We should use type inference instead of explicit type parameters

["ralf0131 (GitHub)" <gi...@apache.org>]

Anything we can do in this issue? Shall we close this issue now? 

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org