You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by phillipkent <gi...@git.apache.org> on 2016/04/26 12:34:10 UTC

[GitHub] cloudstack-cloudmonkey pull request: fix bug in using readline in ...

GitHub user phillipkent opened a pull request:

    https://github.com/apache/cloudstack-cloudmonkey/pull/13

    fix bug in using readline in Windows

    I found a bug with use of 'readline' for Python 2.7 on Windows 7. Cloudmonkey fails to run with this error:
    
    File “c:\python27\lib\site-packages\cloudmonkey\cloudmonkey.py”  line 70 module>
                If ‘libedit’ in readline.__doc__
    TypeError:  argument of type ‘NoneType’ is not iterable
    
    It requires modification of cloudmonkey.py at line 70.
    
    The error and fix are the same as reported here: 
    http://bugs.python.org/issue18852
    https://hg.python.org/cpython/rev/3070fdd58645
    
    Note: I haven't tested this for Cloudmonkey in other Windows versions, or other Python versions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phillipkent/cloudstack-cloudmonkey fix_bug_windows_readline

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack-cloudmonkey/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
    
----
commit 3d9d7795cdc9e3337a3493f2f370d801c4b4b96b
Author: Phillip Kent <ph...@xmlsoup.com>
Date:   2016-04-26T10:21:01Z

    fix bug in using readline in Windows

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-cloudmonkey pull request: fix bug in using readline in ...

Posted by rhtyd <gi...@git.apache.org>.

Github user rhtyd commented on the pull request:

    https://github.com/apache/cloudstack-cloudmonkey/pull/13#issuecomment-218304743
  
    LGTM, based on the changes I think it should work on all Python versions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-cloudmonkey issue #13: fix bug in using readline in Windows

Posted by rhtyd <gi...@git.apache.org>.

Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack-cloudmonkey/pull/13
  
    Thanks for the fix @phillipkent somehow I forgot to merge this. Merging this now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-cloudmonkey pull request #13: fix bug in using readline in Window...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack-cloudmonkey/pull/13


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---