You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by kamilc89 <gi...@git.apache.org> on 2015/01/17 14:59:13 UTC

[GitHub] sling pull request: SLING-4327-added support for custom root paths...

GitHub user kamilc89 opened a pull request:

    https://github.com/apache/sling/pull/56

    SLING-4327-added support for custom root paths for resource resolver

    https://issues.apache.org/jira/browse/SLING-4327
    
    ovide ability to create a ResourceResolver which is aware of any mappings, for example by providing proper argument mappingPath. In case of AEM it would be possible to use publish instance mapping present under etc/publish.map to on author instance.
    To achieve that the CommonResourceResolverFactoryImpl could be implementing methods getResourceResolver() and getAdministrativeResourceResolver() with additional argument defining the mapping location. The advantage of this solution is that the created ResourceResolver can be used many times with the same mappings. The drawback is that the mappings configuration will be found and cached when they resourceresolver will be used for the first time - there is no possibility to define the list of working mappings before.
    The proposal of API change:
    
    {code}
    ResourceResolver getResourceResolver(Map<String, Object> authenticationInfo, String customRootMap) throws LoginException;
     
    ResourceResolver getAdministrativeResourceResolver(Map<String, Object> authenticationInfo, String customRootMap) throws LoginException;
    {code}

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kamilc89/sling SLING-4327-added-support-for-custom-root-paths-for-r

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sling/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #56
    
----
commit e3812ece4b69b904d1fc1b954adf9b6726a3cd25
Author: kamilc89 <ka...@gmail.com>
Date:   2015-01-17T13:54:01Z

    SLING-4327-added support for custom root paths for resource resolver

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---