You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/06/25 20:18:26 UTC

[GitHub] [storm] krichter722 commented on a change in pull request #3035: STORM-3417: Fix checkstyle violations in sql-core

krichter722 commented on a change in pull request #3035: STORM-3417: Fix checkstyle violations in sql-core
URL: https://github.com/apache/storm/pull/3035#discussion_r297374751
 
 

 ##########
 File path: sql/storm-sql-core/src/jvm/org/apache/storm/sql/javac/CompilingClassLoader.java
 ##########
 @@ -125,7 +125,8 @@ public CompilingClassLoader(
     }
 
     /**
-     * @return Whether compilation was successful.
+     * Compiles source code to byte code.
 
 Review comment:
   We removed the rule to add missing Javadoc on public methods and classes. The rules to validate already present Javadoc were present and remained untouched. I think this makes sense because if Javadoc is present it should be valid. It could also be removed but deciding that slows down the PR workflow in my opinion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services