[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2257: Handle metrics during schema transformation

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #2257:
URL: https://github.com/apache/iceberg/pull/2257#discussion_r588749158



##########
File path: core/src/main/java/org/apache/iceberg/MetricsConfig.java
##########
@@ -46,6 +47,35 @@ public static MetricsConfig getDefault() {
     return spec;
   }
 
+  public static Map<String, String> updateProperties(Map<String, String> props, List<String> deletes,

Review comment:
       Seems like we don't need it as public?
   
   I'd also consider a utility class `MetricsConfigUtil` to keep `MetricsConfig` simple. We will need a few helper methods for metrics configs and it may be a good time to introduce a utility class now. That way, we won't have to reason about compatibility when we move to column ids.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org