[GitHub] [geode] demery-pivotal commented on a change in pull request #6951: GEODE-9536: Make PingOp test more patient

[GitBox <gi...@apache.org>]

demery-pivotal commented on a change in pull request #6951:
URL: https://github.com/apache/geode/pull/6951#discussion_r725162576



##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/PingOpDistributedTest.java
##########
@@ -133,11 +133,12 @@ public void regularPingFlow() {
     client.invoke(() -> executePing(poolName, server1Port, distributedMember1));
     Long firstHeartbeat = server1.invoke(this::getSingleHeartBeat);
 
-    client.invoke(() -> executePing(poolName, server1Port, distributedMember1));
-    Long secondHeartbeat = server1.invoke(this::getSingleHeartBeat);
-
-    assertThat(secondHeartbeat).isGreaterThan(firstHeartbeat);
+    GeodeAwaitility.await().untilAsserted(() -> {

Review comment:
       Done. Note that I couldn't use an assertion for that, because awaitility would catch and ignore the `AssertionError`. I explicitly threw an `Error` instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org