[GitHub] [kafka] vamossagar12 edited a comment on pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

[GitBox <gi...@apache.org>]

vamossagar12 edited a comment on pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#issuecomment-741406925


   Thanks @hachikuji . I have assigned the name change issue to myself. I see 1 test failures but those don't seem to be connected to this issue. 
   1 of them is 
   ``` 
   kafka.network.ConnectionQuotasTest > testListenerConnectionRateLimitWhenActualRateAboveLimit FAILED
   08:54:04      java.util.concurrent.ExecutionException: java.lang.AssertionError: Expected rate (30 +- 7), but got 39.12107974180088 (600 connections / 15.337 sec) expected:<30.0> but was:<39.12107974180088>
   08:54:04          at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
   08:54:04          at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:205)
   08:54:04          at kafka.network.ConnectionQuotasTest.$anonfun$testListenerConnectionRateLimitWhenActualRateAboveLimit$3(ConnectionQuotasTest.scala:414)
   08:54:04          at scala.collection.immutable.List.foreach(List.scala:333)
   08:54:04          at kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit(ConnectionQuotasTest.scala:414)
   08:54:04  
   08:54:04          Caused by:
   08:54:04          java.lang.AssertionError: Expected rate (30 +- 7), but got 39.12107974180088 (600 connections / 15.337 sec) expected:<30.0> but was:<39.12107974180088>
   08:54:04              at org.junit.Assert.fail(Assert.java:89)
   08:54:04              at org.junit.Assert.failNotEquals(Assert.java:835)
   08:54:04              at org.junit.Assert.assertEquals(Assert.java:555)
   08:54:04              at kafka.network.ConnectionQuotasTest.acceptConnectionsAndVerifyRate(ConnectionQuotasTest.scala:871)
   08:54:04              at kafka.network.ConnectionQuotasTest.$anonfun$testListenerConnectionRateLimitWhenActualRateAboveLimit$2(ConnectionQuotasTest.scala:412)
   08:54:04
   ``` 
   
   and the other one being:
   ```
   10:12:53  kafka.server.ScramServerStartupTest > testAuthentications FAILED
   10:12:53      org.apache.zookeeper.KeeperException$NoAuthException: KeeperErrorCode = NoAuth for /config/changes
   10:12:53          at org.apache.zookeeper.KeeperException.create(KeeperException.java:120)
   10:12:53          at org.apache.zookeeper.KeeperException.create(KeeperException.java:54)
   10:12:53          at kafka.zookeeper.AsyncResponse.maybeThrow(ZooKeeperClient.scala:583)
   10:12:53          at kafka.zk.KafkaZkClient.createRecursive(KafkaZkClient.scala:1731)
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org